-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the default value of jitter to JITTER_DEFAULT #6055
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6055 +/- ##
==========================================
+ Coverage 87.52% 89.09% +1.56%
==========================================
Files 72 72
Lines 12924 12924
==========================================
+ Hits 11312 11514 +202
+ Misses 1612 1410 -202
|
Hi, not sure why |
Reran the other build that failed, it passes now. The readthedocs build is failing I think because of the same issue upstream with jax that has since been fixed. Is there a way to rerun it to verify? I don't see anything in this PR that might cause an issue with docs. It looks possible but maybe the feature is too new. I may not see a rebuild button because I'm not an admin on RTD, maybe @OriolAbril can see a rebuild button, if you have a sec? |
asked for a rebuild, if it doesn't work it probably needs a rebase |
Thanks for running that @OriolAbril, looks like everythings green now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, and thanks for fixing this @danhphan this will prevent a lot of unnecessary errors for people trying to use this
Hi, thanks @bwengals and @OriolAbril :) |
Hi, thanks @michaelosthege |
This PR makes a minor change in gp models by setting the default value of
jitter
toJITTER_DEFAULT
, instead of0.0
.This could reduce the number of errors (like positive definite errors) when calling
conditional
functions.I am not sure, but I'm not aware if there is any cases that the default jitter of
0.0
will be useful for end users. Please confirm if I'm wrong. Thank you.