Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling with filter owner (#1518) #1525

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: styling with filter owner (#1518) #1525

merged 1 commit into from
Oct 2, 2024

Conversation

oyetanishq
Copy link
Contributor

Description

Fix styling with filter modal owner, and add tooltip on hover over display names.

Fixes (#1518)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I checked that the problem was solved and the filter modal owner the same in all of them.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Before After
Screenshot 2024-10-01 at 22 18 10 react-play-1

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit d623bcf
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/66fc28984971db0008a793ff
😎 Deploy Preview https://deploy-preview-1525--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal linked an issue Oct 2, 2024 that may be closed by this pull request
5 tasks
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 2, 2024
@priyankarpal priyankarpal merged commit d711605 into reactplay:main Oct 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Styling Issue with Filter Owner
2 participants