Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Bug report]: Styling Issue with Filter Owner #1518

Closed
4 of 5 tasks
Shivam-Katare opened this issue Oct 1, 2024 · 8 comments · Fixed by #1525
Closed
4 of 5 tasks

🐛 [Bug report]: Styling Issue with Filter Owner #1518

Shivam-Katare opened this issue Oct 1, 2024 · 8 comments · Fixed by #1525
Assignees
@oyetanishq
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase bug Something isn't working 🛠 goal: fix Bug fix hacktoberfest 🏁 status: ready for dev Ready for work

Comments

@Shivam-Katare
Copy link
Contributor

Shivam-Katare commented Oct 1, 2024 •
edited by priyankarpal
Loading

Descrcibe the bug?

The filter by owners should be correctly aligned and in a single line.

Steps to reproduce the bug?

  1. Go to the ReactPlay Site
  2. Click on the Browse button
  3. Click on the filter option at the top side of your screen
  4. Click on the Owners Filter to see unmatched styling

Expected behavior

The filter owners should be correctly aligned and in a single line. If a name is too long, we can truncate it with ... and show the full name in a tooltip on hover. The current styling looks weird.

Desktop (Please provide your system information)

OS: Windows
Browser: Chrome

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

image

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Shivam-Katare Shivam-Katare added bug Something isn't working hacktoberfest 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@oyetanishq
Copy link
Contributor

can you please assign it to me? I want to work on this.

@Sachin-chaurasiya
Copy link
Member

can you please assign it to me? I want to work on this.

Hey @tanishq-singh-2407 , sure assigned to you, feel free to join ReactPlay Discord Community.

@priyankarpal priyankarpal added 🏁 status: ready for dev Ready for work and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 1, 2024
@priyankarpal
Copy link
Member

can you please assign it to me? I want to work on this.

are you into hacktoberfest?

@oyetanishq
Copy link
Contributor

Yes

@priyankarpal
Copy link
Member

Yes

ok

@oyetanishq
Copy link
Contributor

oyetanishq commented Oct 1, 2024 •
edited
Loading

Looks something like this!
react-play-1

@oyetanishq oyetanishq mentioned this issue Oct 1, 2024
Merged
11 tasks
@priyankarpal
Copy link
Member

Looks something like this! react-play-1

looks good to me

@priyankarpal priyankarpal linked a pull request Oct 2, 2024 that will close this issue
fix: styling with filter owner (#1518) #1525
Merged
11 tasks
priyankarpal pushed a commit that referenced this issue Oct 2, 2024
@oyetanishq
fix: styling with filter owner (#1518) (#1525)
d711605
@priyankarpal priyankarpal added the 🤖 aspect: dx Concerns developers' experience with the codebase label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyetanishq oyetanishq

Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase bug Something isn't working 🛠 goal: fix Bug fix hacktoberfest 🏁 status: ready for dev Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: styling with filter owner (#1518)
4 participants
@Sachin-chaurasiya @oyetanishq @priyankarpal @Shivam-Katare