Add hide! utility function. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeits
reviewed
Apr 5, 2019
src/abstract_visualizer.jl
Outdated
| setobject!(vis::AbstractVisualizer, geom::GeometryLike) = setobject!(vis, Object(geom)) | ||
| setobject!(vis::AbstractVisualizer, geom::GeometryLike, material::AbstractMaterial) = setobject!(vis, Object(geom, material)) | ||
| hide!(vis::AbstractVisualizer) = settransform!(vis, LinearMap(UniformScaling(false))) |
There was a problem hiding this comment.
I think setprop!(vis, "visible", false) might be a more idiomatic way to do this. What do you think?
There was a problem hiding this comment.
Yes. I thought you might have a suggestion like that, but I didn't know the right API call. I'll change it.
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 73.2% 73.29% +0.08%
==========================================
Files 12 12
Lines 321 322 +1
==========================================
+ Hits 235 236 +1
Misses 86 86
Continue to review full report at Codecov.
|
|
Done, but I guess this should now be |
|
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #96.