Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mux to be compatible with HTTP 0.8. #96

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Mar 26, 2019

With MeshCat deved, I was getting the following:

using MeshCat

WARNING: could not import HTTP.HandlerFunction into Mux
ERROR: LoadError: LoadError: UndefVarError: Server not defined
Stacktrace:
 [1] top-level scope at none:0
 [2] include at ./boot.jl:326 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1038
 [4] include at ./sysimg.jl:29 [inlined]
 [5] include(::String) at /home/twan/.julia/packages/Mux/11dSG/src/Mux.jl:1
 [6] top-level scope at none:0
 [7] include at ./boot.jl:326 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1038
 [9] include(::Module, ::String) at ./sysimg.jl:29
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:328 [inlined]
 [12] eval(::Expr) at ./client.jl:404
 [13] top-level scope at ./none:3
in expression starting at /home/twan/.julia/packages/Mux/11dSG/src/server.jl:56
in expression starting at /home/twan/.julia/packages/Mux/11dSG/src/Mux.jl:24
ERROR: LoadError: Failed to precompile Mux [a975b10e-0019-58db-a62f-e48ff68538c9] to /home/twan/.julia/compiled/v1.1/Mux/cs9xb.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1197
 [3] _require(::Base.PkgId) at ./loading.jl:960
 [4] require(::Base.PkgId) at ./loading.jl:858
 [5] require(::Module, ::Symbol) at ./loading.jl:853
 [6] include at ./boot.jl:326 [inlined]
 [7] include_relative(::Module, ::String) at ./loading.jl:1038
 [8] include(::Module, ::String) at ./sysimg.jl:29
 [9] top-level scope at none:2
 [10] eval at ./boot.jl:328 [inlined]
 [11] eval(::Expr) at ./client.jl:404
 [12] top-level scope at ./none:3
in expression starting at /home/twan/.julia/dev/MeshCat/src/MeshCat.jl:6

Failed to precompile MeshCat [283c5d60-a78f-5afe-a0af-af636b173e11] to /home/twan/.julia/compiled/v1.1/MeshCat/CZdjb.ji.

Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1197
 [3] _require(::Base.PkgId) at ./loading.jl:960
 [4] require(::Base.PkgId) at ./loading.jl:858
 [5] require(::Module, ::Symbol) at ./loading.jl:853
 [6] top-level scope at In[2]:1

This is because Mux 0.5.3 (the latest 0.5.x version) is not compatible with HTTP 0.8, but Mux has not specified upper bounds on its HTTP compatibility.

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #96 into master will increase coverage by 3.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
+ Coverage   69.52%   73.2%   +3.68%     
=========================================
  Files          12      12              
  Lines         338     321      -17     
=========================================
  Hits          235     235              
+ Misses        103      86      -17
Impacted Files Coverage Δ
src/servers.jl 4.54% <0%> (+0.37%) ⬆️
src/MeshCat.jl 30.43% <0%> (+2.43%) ⬆️
src/lowering.jl 83.33% <0%> (+2.45%) ⬆️
src/objects.jl 100% <0%> (+3.84%) ⬆️
src/visualizer.jl 74.64% <0%> (+9.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2ce73...04ee8bc. Read the comment docs.

@dehann
Copy link
Contributor

dehann commented Mar 27, 2019

HI @tkoolen thanks! FYI, I also ran into this yesterday and was able to get Mux#master to work with HTTP 0.8. There is a fix and open issue on Mux to tag a new release -- looks like it could happen soon.

@tkoolen
Copy link
Collaborator Author

tkoolen commented Mar 27, 2019

Should be merged already, JuliaLang/METADATA.jl#22382 / https://github.com/JuliaWeb/Mux.jl/releases/tag/v0.7.0.

This was referenced Mar 27, 2019
@rdeits
Copy link
Owner

rdeits commented Apr 5, 2019

Thank you!

@rdeits rdeits merged commit 4f6771c into rdeits:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants