-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #80, extents of Cylinder is a Point, not a Vec. #81
Conversation
Whoops. I used to provide my own HyperCylinder type which used a different convention--looks like I got it wrong when I switched to the GeometryTypes.Cylinder type. This is a breaking change, right? Presumably we'll need to update MechanismGeometries.jl as well. |
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 70.05% 70.05%
=======================================
Files 12 12
Lines 334 334
=======================================
Hits 234 234
Misses 100 100
Continue to review full report at Codecov.
|
Yeah, it's a breaking change. |
Ok, I just tagged 0.5.0, so we can merge this and then tag 0.6.0 and update MechanismGeometries. |
Huh, TIL you can make a merge commit and resolve conflicts in the github web interface. Neat. |
Oh, but I didn't do it properly. One moment... |
fix bad merge
Sorry for the delay on this--I was waiting for JuliaLang/METADATA.jl#20002 and then I got distracted. |
No description provided.