Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #80, extents of Cylinder is a Point, not a Vec. #81

Merged
merged 4 commits into from
Dec 20, 2018

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Dec 10, 2018

No description provided.

@rdeits
Copy link
Owner

rdeits commented Dec 11, 2018

Whoops. I used to provide my own HyperCylinder type which used a different convention--looks like I got it wrong when I switched to the GeometryTypes.Cylinder type.

This is a breaking change, right? Presumably we'll need to update MechanismGeometries.jl as well.

@rdeits rdeits closed this Dec 11, 2018
@rdeits rdeits reopened this Dec 11, 2018
@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files          12       12           
  Lines         334      334           
=======================================
  Hits          234      234           
  Misses        100      100
Impacted Files Coverage Δ
src/lowering.jl 80.88% <ø> (ø) ⬆️
src/geometry.jl 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d267509...5bfac00. Read the comment docs.

@tkoolen
Copy link
Collaborator Author

tkoolen commented Dec 11, 2018

Yeah, it's a breaking change.

@rdeits
Copy link
Owner

rdeits commented Dec 11, 2018

Ok, I just tagged 0.5.0, so we can merge this and then tag 0.6.0 and update MechanismGeometries.

@rdeits
Copy link
Owner

rdeits commented Dec 11, 2018

Huh, TIL you can make a merge commit and resolve conflicts in the github web interface. Neat.

@rdeits
Copy link
Owner

rdeits commented Dec 11, 2018

Oh, but I didn't do it properly. One moment...

@rdeits
Copy link
Owner

rdeits commented Dec 20, 2018

Sorry for the delay on this--I was waiting for JuliaLang/METADATA.jl#20002 and then I got distracted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants