Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylinder handling #80

Closed
tkoolen opened this issue Dec 10, 2018 · 0 comments
Closed

Cylinder handling #80

tkoolen opened this issue Dec 10, 2018 · 0 comments

Comments

@tkoolen
Copy link
Collaborator

tkoolen commented Dec 10, 2018

I was surprised by

MeshCat.jl/src/geometry.jl

Line 32 in d93d0a7

center(geometry::Cylinder) = origin(geometry) + geometry.extremity / 2

and

MeshCat.jl/src/geometry.jl

Line 51 in d93d0a7

R = rotation_between(SVector(0, 1, 0), g.extremity)

The extremity field of a Cylinder is a Point, not a Vec, so I would have expected

center(geometry::Cylinder) = (origin(geometry) + geometry.extremity) / 2

and

R = rotation_between(SVector(0, 1, 0), g.extremity - g.origin)
@rdeits rdeits closed this as completed in 0596a0f Dec 20, 2018
rdeits added a commit that referenced this issue Dec 20, 2018
@rdeits
Merge pull request #81 from tkoolen/tk/fix-cylinder
17c701d 
Fix #80, extents of Cylinder is a Point, not a Vec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkoolen