Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid some dict lookups and a few allocations #101

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Apr 11, 2019

Minor change on top of #100 which avoids a couple of extra Dict allocations by using get! instead of get

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #101 into master will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   73.45%   73.84%   +0.38%     
==========================================
  Files          12       12              
  Lines         324      367      +43     
==========================================
+ Hits          238      271      +33     
- Misses         86       96      +10
Impacted Files Coverage Δ
src/visualizer.jl 75.34% <100%> (ø) ⬆️
src/lowering.jl 80% <0%> (-3.34%) ⬇️
src/geometry.jl 94.28% <0%> (-1.37%) ⬇️
src/MeshCat.jl 40% <0%> (+9.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b4fb6...db274ed. Read the comment docs.

@rdeits rdeits merged commit 43f206f into master Apr 11, 2019
@rdeits rdeits deleted the perf-updates branch April 11, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants