Set default value for iframe style dict. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 73.2% 73.37% +0.16%
==========================================
Files 12 12
Lines 321 323 +2
==========================================
+ Hits 235 237 +2
Misses 86 86
Continue to review full report at Codecov.
|
twavv
force-pushed
the
travigd/set-iframe-default-style
branch
from
4964695 to
7220b91
Compare
|
This, together with JuliaGizmos/WebIO.jl#266 and #99, makes MeshCat.jl work (at the very least, all tests pass) using |
1 task
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code was relying on an implementation detail where
iframe.scope.dom.props[:style]was set (in particular it hadoverflow: none). The WebIO rework doesn't set this by default, which causes an error when usingWebIO#master.