-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamic plugin should support pulling image with digest #1280
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 61.72% 61.69% -0.04%
==========================================
Files 97 97
Lines 6190 6192 +2
==========================================
- Hits 3821 3820 -1
- Misses 2038 2040 +2
- Partials 331 332 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, thanks for the fix!
LGTM, thanks for the fix! |
Description
What this PR does / why we need it:
The download logic uses the source object to form the blob reference. However when a digest is used, the reference becomes malformed as the regex that looks for the blob reference would parse out the digest.
When a tag is passed:
{wabbitnetworks.azurecr.io/test/sample-store-plugin:v1 map[]}@sha256:26d320ceaa2d027ea2bceaae36a82e304782bbbbe92c8f0b1102482c596f32f5 (blob reference)
When a digest is passed:
{wabbitnetworks.azurecr.io/test/sample-store-plugin:294c517b9432a59f2d829f6d04912833a256560e4128aca86efa0c6b4ba6d44 map[]}@sha256:26d320ceaa2d027ea2bceaae36a82e304782bbbbe92c8f0b1102482c596f32f5 (blob reference)
@binbin-li followed up with Oras folks to confirm only the reference is required. This PR updates the code path to ONLY pass the blob to the oras library.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1278
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Locally tested with dynamic plugin both using tag and digest
Checklist:
Post Merge Requirements
Helm Chart Change