Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic plugin should support pulling image with digest #1278

Closed
1 task done
susanshi opened this issue Jan 24, 2024 · 0 comments · Fixed by #1280
Closed
1 task done

Dynamic plugin should support pulling image with digest #1278

susanshi opened this issue Jan 24, 2024 · 0 comments · Fixed by #1280
Assignees
Labels
bug Something isn't working triage Needs investigation

Comments

@susanshi
Copy link
Collaborator

What happened in your environment?

This issue was reported by a Ratify contributor:

Plugins with source property as a tag works, the same image with digest specified should also work.

Tag: wabbitnetworks.azurecr.io/test/sample-verifier-plugin:v1
digest: wabbitnetworks.azurecr.io/test/sample-verifier-plugin@sha256:294c517b9432a59f2d829f6d04912833a256560e4128aca86efa0c6b4ba6d44d

What did you expect to happen?

Current pulls with a digest fails with an error. Digest should be supported as tag is mutable.

What version of Kubernetes are you running?

No response

What version of Ratify are you running?

v1.1

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this bug fix?

  • Yes, I am willing to implement it.
@susanshi susanshi added bug Something isn't working triage Needs investigation labels Jan 24, 2024
@susanshi susanshi self-assigned this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant