Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names in logging macro calls #897

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Oct 25, 2021

Fixes #896 .

When variable names were changed to satisfy clang-tidy improvements, these were missed because the macros are compiled out unless higher logging levels are enabled on the compiler command line.

@harrism harrism added bug Something isn't working non-breaking Non-breaking change cpp Pertains to C++ code labels Oct 25, 2021
@harrism harrism self-assigned this Oct 25, 2021
@harrism harrism requested a review from a team as a code owner October 25, 2021 23:52
@harrism harrism requested review from rongou and codereport October 25, 2021 23:52
@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c07f1c8 into rapidsai:branch-21.12 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Build fails when RMM_LOGGING_LEVEL is set to TRACE
3 participants