Skip to content

Commit

Permalink
Fix variable names in logging macro calls (#897)
Browse files Browse the repository at this point in the history
Fixes #896 .

When variable names were changed to satisfy clang-tidy improvements, these were missed because the macros are compiled out unless higher logging levels are enabled on the compiler command line.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Rong Ou (https://github.com/rongou)
  - Conor Hoekstra (https://github.com/codereport)

URL: #897
  • Loading branch information
harrism authored Oct 27, 2021
1 parent 0fbe357 commit c07f1c8
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class stream_ordered_memory_resource : public crtp<PoolResource>, public device_
*/
void* do_allocate(std::size_t size, cuda_stream_view stream) override
{
RMM_LOG_TRACE("[A][stream {:p}][{}B]", fmt::ptr(stream.value()), bytes);
RMM_LOG_TRACE("[A][stream {:p}][{}B]", fmt::ptr(stream.value()), size);

if (size <= 0) { return nullptr; }

Expand All @@ -214,7 +214,7 @@ class stream_ordered_memory_resource : public crtp<PoolResource>, public device_

RMM_LOG_TRACE("[A][stream {:p}][{}B][{:p}]",
fmt::ptr(stream_event.stream),
bytes,
size,
fmt::ptr(block.pointer()));

log_summary_trace();
Expand All @@ -233,7 +233,7 @@ class stream_ordered_memory_resource : public crtp<PoolResource>, public device_
*/
void do_deallocate(void* ptr, std::size_t size, cuda_stream_view stream) override
{
RMM_LOG_TRACE("[D][stream {:p}][{}B][{:p}]", fmt::ptr(stream.value()), bytes, p);
RMM_LOG_TRACE("[D][stream {:p}][{}B][{:p}]", fmt::ptr(stream.value()), size, ptr);

if (size <= 0 || ptr == nullptr) { return; }

Expand Down

0 comments on commit c07f1c8

Please sign in to comment.