Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] rapids-cmake v25.02 #763

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

[RELEASE] rapids-cmake v25.02 #763

wants to merge 26 commits into from

Conversation

AyodeAwe
Copy link
Contributor

❄️ Code freeze for branch-25.02 and v25.02 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-25.02 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-25.02 into main for the release

raydouglass and others added 26 commits November 15, 2024 09:25
@raydouglass
DOC v25.02 Updates [skip ci]
9f89c0b
@AyodeAwe
add breaking change notifier (#719)
fa61767
@bdice
Update to CCCL 2.7.0-rc2. (#710)
83ff6f1
@GPUtester
Merge pull request #726 from rapidsai/branch-24.12
7e3122c 
Forward-merge branch-24.12 into branch-25.02
@AyodeAwe
Update version references in workflow (#729)
1d17891 
Update version references in breaking-change trigger workflow
@GPUtester
Merge pull request #730 from rapidsai/branch-24.12
ca12bcd 
Forward-merge branch-24.12 into branch-25.02
@robertmaynard
Correct nvbench + conda test to explicitly pull spdlog (#733)
5a635b1 
As of rapidsai/rmm#1722, rmm no longer depends on spdlog. However, some tests were depending on spdlog transitively through rmm. This PR adds spdlog as an explicit dependency to correct those failures.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #733
@PointKernel
Bump cuco version to fetch various fixes and new features (#723)
36e12b6 
This PR bumps the cuco version to mainly fetch the bucket storage update and bloom filter fixes.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #723
@jameslamb
fix signature in rapids_export() docs (#732)
dcbd3ad 
Reading through https://docs.rapids.ai/api/rapids-cmake/stable/command/rapids_export/, I noticed what looks like a typo... argument `COMPONENTS` is repeated in the signature of `rapids_export()`. I think that second one was supposed to be `COMPONENTS_EXPORT_SET`.

This fixes that.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #732
@vyasr
Require Cython to be found (#734)
6d6c07b 
Resolves #731

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #734
@mhaseeb123
Bump cuco by one commit to include cuco::arrow_filter_policy updates (
faef975 
#735)

Simply bump cuco by one commit which contains updates to unblock rapidsai/cudf#17289

Authors:
  - Muhammad Haseeb (https://github.com/mhaseeb123)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #735
@jameslamb
remove setup.cfg, use pyproject.toml (#736)
840accd 
This repo doesn't have a Python package or use `setuptools`, but it has a `setup.cfg`... to hold configuration for tools like `codespell`.

This proposes removing that and using a `pyproject.toml` to store that configuration, matching the conventions used across most of the rest of RAPIDS.

It also updates pre-commit configurations to use the latest version of `rapids-dependency-file-generator` (v1.17.0).

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #736
@vyasr
Add rapids-logger (#737)
3a9d5d8 
This PR adds support for fetching [`rapids-logger`](https://github.com/rapidsai/rapids-logger/) using rapids-cmake to ensure a consistent version is used by all RAPIDS libraries.

Contributes to rapidsai/build-planning#104.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #737
@vyasr
Update logger hash (#738)
ab8cd16 
Updates rapids-logger to pick up rapidsai/rapids-logger#8.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #738
@vyasr
Add new global targets for rmm (#739)
549c677 
These targets were added in rapidsai/rmm#1722 and must be propagated.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #739
@robertmaynard
rapids_cpm_cccl use proper CCCL version value to compute install rules (
fa580e5 
#742)

We can't use the request versions.json version value as it might be 2.7 and we found >= 2.8

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #742
@bdice
Use CCCL v2.7.0 final tag. (#743)
af4fe43 
CCCL is currently pinned to `v2.7.0-rc2`. Now that a final tag for `v2.7.0` is available, we should use that instead.

See diff: NVIDIA/cccl@v2.7.0-rc2...v2.7.0

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #743
@bdice
Use GCC 13 in CUDA 12 conda builds. (#741)
f5e37e8 
conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.

These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #741
@PointKernel
Fetch cuco filter alignment fix to unblock RAPIDS CI (#744)
f2e0216 
This PR bumps cuco version to fetch a bloom filter alignment fix.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #744
@robertmaynard
Add support for new architectures in CUDA 12.8 (#746)
3a35e72 
Adds the new CUDA architectures in 12.8

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - https://github.com/jakirkham

URL: #746
@bdice
Use sysroot 2.17 on CUDA < 11.8. (#745)
e84fd34 
Nightly CI was failing on CUDA 11.4 due to #741. This fixes it.
Old versions of `nvcc` for CUDA 11 do not support sysroot 2.28 until CUDA 11.8.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #745
@bdice
Allow sysroot 2.28 in CUDA 11 jobs. (#749)
3f8cc2b 
This removes some special cases added in #745 around sysroot pinnings. Those were needed for CUDA 11.4 until a recent repodata patch. Thanks @jakirkham!

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham

URL: #749
@robertmaynard
Fea/support embedded patch content (#728)
36939de 
rapids-cmake versions.json files now support embedded patch files. This feature is leveraged by rapids-cmake generated pinned `versions.json` to make the file full relocatable.

Fixes #718

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #728
@bdice
Build and test with CUDA 12.8.0 (#754)
396d4c5 
This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - James Lamb (https://github.com/jameslamb)

URL: #754
@robertmaynard
Backport cccl PR 3578 to v2.7 to unblock CUDA 12.8 builds (#756)
a26c5c9 
Required for at least cugraph 25.02 to build with CUDA 12.8

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #756
@vyasr
Revert CUDA 12.8 shared workflow branch changes (#759)
f484e92 
This PR points the shared workflow branches back to the default 25.02 branches.

xref: rapidsai/build-planning#139

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #759
@AyodeAwe AyodeAwe requested review from a team as code owners January 31, 2025 21:39
@AyodeAwe AyodeAwe requested a review from jameslamb January 31, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/packaging-codeowners

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AyodeAwe @raydouglass @bdice @GPUtester @robertmaynard @PointKernel @jameslamb @vyasr @mhaseeb123