Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Cython to be found #734

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Require Cython to be found #734

merged 2 commits into from
Dec 17, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 16, 2024

Description

Resolves #731

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 16, 2024
@vyasr vyasr self-assigned this Dec 16, 2024
@vyasr vyasr requested a review from a team as a code owner December 16, 2024 22:21
@vyasr vyasr requested a review from a team as a code owner December 17, 2024 20:04
@vyasr vyasr requested review from KyleFromNVIDIA and removed request for a team December 17, 2024 20:04
@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6d6c07b into branch-25.02 Dec 17, 2024
15 checks passed
@vyasr vyasr deleted the vyasr-patch-1 branch December 17, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cython_init() can silently fail to find Cython
2 participants
@vyasr @bdice