-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapids-cython component for scikit-build based Python package builds #184
Conversation
Please add |
The function names need to change to match the rapids-cmake style so |
…ify initialization.
In addition to the inline TODOs, I have one additional question. Currently the |
|
…ctually overrides the linker script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of doc changes and we are good to go
@robertmaynard I've addressed the two final requests that you had. There are also a couple of TODO items that I had questions about in the tests, |
@gpucibot merge |
1 similar comment
@gpucibot merge |
…1031) The custom CMake code written in python/cmake has now been generalized and ported to rapids-cmake so that it can be shared across rapids libraries. This PR depends on rapidsai/rapids-cmake#184 and tests will not pass until that is merged. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - https://github.com/jakirkham URL: #1031
This PR introduces various utilities that will be used across all RAPIDS Python packages that are built using scikit-build. Centralizing these utilities reduces the CMake configurations of our Python libraries to a minimum. For now, all of the content is purely CMake code, so this repo is a good place for them. If we ever add Python utilities (e.g. to simplify setup.py scripts) we may need to move to a new repo rather than polluting rapids-cmake with Python code.