-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement all binary operations that depend only on point-in-polygon #834
Implement all binary operations that depend only on point-in-polygon #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass to the code. Strategy pattern does makes sense here.
python/cuspatial/cuspatial/tests/binops/test_pip_only_binops.py
Outdated
Show resolved
Hide resolved
python/cuspatial/cuspatial/tests/binops/test_pip_only_binops.py
Outdated
Show resolved
Hide resolved
python/cuspatial/cuspatial/tests/binops/test_pip_only_binops.py
Outdated
Show resolved
Hide resolved
… instead of __init__.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's .contains_properly
?
NM, it's from the last PR.
rerun tests |
rerun tests |
Co-authored-by: Mark Harris <[email protected]>
Co-authored-by: Mark Harris <[email protected]>
Thanks Mark, I updated the docs as you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More doc suggestions, but pre-approving.
Co-authored-by: Mark Harris <[email protected]>
@gpucibot merge |
Closes #722
Closes #835
Description
This PR begins the refactoring of binary operations code to support every binary operation and combination of inputs. A new test file is created,
tests/binops/test_pip_only_binpreds.py
that contains a size 1 and a size 31 case for each binop combination that should work with only.contains_properly
. Three binary predicates are partially implemented in this PR: overlaps, intersects, and within.The following tests are implemented in this binpred:
Checklist