Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Implement binary predicates that depend only on point-in-polygon #722

Closed
11 tasks done
thomcom opened this issue Oct 3, 2022 · 4 comments · Fixed by #834
Closed
11 tasks done

[FEA] Implement binary predicates that depend only on point-in-polygon #722

thomcom opened this issue Oct 3, 2022 · 4 comments · Fixed by #834
Assignees
Labels
4 - Needs Reviewer Waiting for reviewer to review or respond feature request New feature or request
Milestone

Comments

@thomcom
Copy link
Contributor

thomcom commented Oct 3, 2022

Is your feature request related to a problem? Please describe.
Some spatial predicates depend only on the outcome of point-in-polygon.

Describe the solution you'd like
I can work on these predicates in python while the equals and intersects basic predicates are being worked on.

Equality/Intersection/PIP table
Legend:
x: False/impossible
e: uses equality
i: uses intersection
p: uses pip

  x(p, p) x(p, l) x(p, P) x(l, p) x(l, l) x(l, P) x(P, p) x(P, l) x(P, P)
Equals e x x x e e e e e
Disjoint e e e i i ip ep ep ep
Touches e e p i i ip ip ip ip
Contains e x x i e x p p p
Covers e x x i e x ip ip ip
Intersects e e p i i i ip ip ip
Within e e p x e p x x p
CoveredBy e e p x e p x x p
Crosses e x x i i i i i i
Overlaps e x x i i i p i i

#722 (comment)

@thomcom thomcom added feature request New feature or request Needs Triage Need team to review and classify labels Oct 3, 2022
@thomcom thomcom removed the Needs Triage Need team to review and classify label Oct 3, 2022
@thomcom thomcom self-assigned this Oct 3, 2022
@thomcom thomcom added this to the DE-9IM milestone Oct 3, 2022
@thomcom thomcom added this to cuSpatial Oct 3, 2022
@thomcom thomcom moved this to Todo in cuSpatial Oct 3, 2022
@thomcom thomcom moved this from Todo to In Progress in cuSpatial Oct 17, 2022
@harrism
Copy link
Member

harrism commented Nov 21, 2022

@thomcom please add a tasklist and use this issue as an epic.

@thomcom
Copy link
Contributor Author

thomcom commented Dec 1, 2022

I implemented them all yesterday morning. They are implemented insofar as only point-in-polygon, with the exception of boundary testing, is required.

@harrism
Copy link
Member

harrism commented Dec 1, 2022

Goal of task lists is for each task to become an issue to give one place.to track an epic. If these are all done in one go, probably didn't need a task list. :)

@thomcom
Copy link
Contributor Author

thomcom commented Dec 1, 2022

It was shorter and easier than I expected - I didn't end up making any separate issues out of it, just writing them up and testing them as I went. I'm working on a refactor that will close this issue hopefully soon.

@harrism harrism moved this from In Progress to Review in cuSpatial Dec 5, 2022
@thomcom thomcom added the 4 - Needs Reviewer Waiting for reviewer to review or respond label Dec 14, 2022
@rapids-bot rapids-bot bot closed this as completed in #834 Dec 15, 2022
Repository owner moved this from Review to Done in cuSpatial Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Reviewer Waiting for reviewer to review or respond feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants