Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add goreleaser #921

Merged
merged 38 commits into from
Feb 13, 2025
Merged

feat: add goreleaser #921

merged 38 commits into from
Feb 13, 2025

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Jan 24, 2025 •
edited
Loading

  • Linux (deb)
  • Linux (rpm)
  • winget (untested)
  • cargo publish
  • now that we use goreleaser, would we like to publish to more package managers? also, configure some announcers like X, etc? (It can be a follow up PR)
  • Notarization Apple
  • brew bump-cask-pr

caarlos0
caarlos0 reviewed Jan 25, 2025
View reviewed changes
caarlos0
caarlos0 reviewed Jan 25, 2025
View reviewed changes
caarlos0
caarlos0 reviewed Jan 25, 2025
View reviewed changes
caarlos0
caarlos0 reviewed Jan 25, 2025
View reviewed changes
@raphamorim raphamorim mentioned this pull request Feb 8, 2025
Closed
5 tasks
@raphamorim
Copy link
Owner

Closing this in favor of #944

Thank you so much for the PR <3

@raphamorim raphamorim closed this Feb 8, 2025
@raphamorim raphamorim reopened this Feb 11, 2025
vedantmgoyal9 and others added 21 commits February 11, 2025 16:16
@vedantmgoyal9
feat: add goreleaser
51d69d0
@vedantmgoyal9
fix(ci/goreleaser): remove steps with empty run field
a1b35ca
@vedantmgoyal9
ci: fix condition and don't release if cache was hit
c94ba9f
@vedantmgoyal9
fix(ci): goreleaser needs fetch-depth: 0 to work
ed1fd85
@vedantmgoyal9
[goreleaser] several fixes and improvements to config and ci
86346ec
@vedantmgoyal9
ci(goreleaser): don't build windows until msi is fixed
5036cc9
@vedantmgoyal9
fix(goreleaser): app bundle embedding thin binary instead of fat binary
e216ac5
@vedantmgoyal9
concurrency
1ba8037
@vedantmgoyal9
build portables for windows (msi is still is disabled)
a89b404
@vedantmgoyal9
test msi again with wix 5.0.2
656be99
@vedantmgoyal9
install wix v5 in ci instead of goreleaser before hooks
dad2ef4 
it doesn't work if we install wix v5 in goreleaser's before hooks because PATH doesn't get updated until we open a new shell.
@vedantmgoyal9
ci: fix windows cache restore on linux
60cc38d
@vedantmgoyal9
disable msi, needs work at goreleaser side
33f68df
@vedantmgoyal9
update according to new changes
6c57e97
@vedantmgoyal9
install wix extensions globally
0538d63
@vedantmgoyal9
🤦🏻‍♂️
4d038e9
@vedantmgoyal9
update
2b5ebac
@vedantmgoyal9
some fixes related to msi
864b792
@vedantmgoyal9
try one more time 😤
680fcc8
@vedantmgoyal9 @caarlos0
Apply suggestions from code review
f6879a4 
Co-authored-by: Carlos Alexandro Becker <[email protected]>
@vedantmgoyal9
😭🤧
28c6a32
@raphamorim raphamorim mentioned this pull request Feb 13, 2025
Closed
@vedantmgoyal9 vedantmgoyal9 mentioned this pull request Feb 13, 2025
Merged
8 tasks
@raphamorim
Copy link
Owner

legendary PR, thanks @vedantmgoyal9

@raphamorim raphamorim merged commit e5c0941 into raphamorim:main Feb 13, 2025
@vedantmgoyal9 vedantmgoyal9 removed their assignment Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 left review comments

@raphamorim raphamorim raphamorim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Rio terminal 0.2.x
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedantmgoyal9 @raphamorim @caarlos0