Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rio 0.2.8 #201527

Merged
merged 1 commit into from
Feb 26, 2025
Merged

rio 0.2.8 #201527

merged 1 commit into from
Feb 26, 2025

Conversation

vedantmgoyal9
Copy link
Contributor

Blocked until next rio release. (raphamorim/rio#921)


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@p-linnane
Copy link
Member

Seems counterproductive to intentionally remove version information from the .dmg filename.

@vedantmgoyal9
Copy link
Contributor Author

It maybe, but this has been done so that users can use GitHub-provided latest URL in their automation scripts - https://github.com/vedantmgoyal9/rio/releases/latest/download/rio.dmg. This way, we don't have to maintain our own URLs which redirect to latest release.

@khipp khipp changed the title fix(rio): new dmg url (wip) rio 0.2.8 Feb 26, 2025
@khipp khipp marked this pull request as ready for review February 26, 2025 19:43
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @vedantmgoyal9! 🎉

@khipp khipp enabled auto-merge February 26, 2025 19:46
@khipp khipp merged commit 587263f into Homebrew:master Feb 26, 2025
11 checks passed
@vedantmgoyal9 vedantmgoyal9 deleted the patch-1 branch February 27, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants