Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] SQL cache backports #431

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

moio
Copy link
Contributor

@moio moio commented Dec 20, 2024

This backports #400, #430, #284, #433

#284 needed some minor adaptation, mostly due to the different mocking framework

I hope this helps

moio added 2 commits December 20, 2024 15:58
* Change indexed fields according to https://github.com/rancher/rancher/issues/48256wq

Signed-off-by: Silvio Moioli <[email protected]>

* Fix typo

---------

Signed-off-by: Silvio Moioli <[email protected]>
@moio moio requested a review from a team as a code owner December 20, 2024 15:12
* bump lasso to include pull rancher#111

Signed-off-by: Silvio Moioli <[email protected]>

* Make IsListWatchable public to be reused in other packages

Signed-off-by: Silvio Moioli <[email protected]>

* Let lasso know whether a type is watchable upon requesting a cache

Signed-off-by: Silvio Moioli <[email protected]>

* Adapt existing tests

Signed-off-by: Silvio Moioli <[email protected]>

* Add a test to check watchability is detected correctly

Signed-off-by: Silvio Moioli <[email protected]>

---------

Signed-off-by: Silvio Moioli <[email protected]>
@moio moio force-pushed the vai_backports_2024 branch from d04ecd8 to f63f2ae Compare December 20, 2024 15:18
@tomleb
Copy link
Contributor

tomleb commented Dec 20, 2024

The branch here should be release/v0.3 according to https://github.com/rancher/steve/blob/main/VERSION.md. We'll be deleting the older branches later, after we fully transition.

@moio moio changed the base branch from release/v2.9 to release/v0.3 January 7, 2025 10:33
@moio
Copy link
Contributor Author

moio commented Jan 7, 2025

Base changed

Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about kubernetes version bump and another about Vai in lasso.

go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@tomleb tomleb requested a review from ericpromislow January 8, 2025 15:04
@moio moio force-pushed the vai_backports_2024 branch 2 times, most recently from c8d73fa to 67e3385 Compare January 9, 2025 13:50
@moio moio requested a review from tomleb January 9, 2025 13:55
Signed-off-by: Silvio Moioli <[email protected]>
@moio moio force-pushed the vai_backports_2024 branch from 67e3385 to adf7a21 Compare January 9, 2025 13:57
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change but otherwise looks good

go.mod Outdated Show resolved Hide resolved
Co-authored-by: Tom Lebreux <[email protected]>
@moio moio requested a review from tomleb January 9, 2025 14:07
tomleb
tomleb previously approved these changes Jan 9, 2025
* Update indexed fields

* Add .status.currentReplicas
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I got caught up on the target branch -- the sooner we can align all the release branch names the better.

@moio moio merged commit b88abd9 into rancher:release/v0.3 Jan 10, 2025
1 check passed
@moio moio deleted the vai_backports_2024 branch January 10, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants