-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.9] SQL cache backports #431
Conversation
Signed-off-by: Silvio Moioli <[email protected]>
* Change indexed fields according to https://github.com/rancher/rancher/issues/48256wq Signed-off-by: Silvio Moioli <[email protected]> * Fix typo --------- Signed-off-by: Silvio Moioli <[email protected]>
* bump lasso to include pull rancher#111 Signed-off-by: Silvio Moioli <[email protected]> * Make IsListWatchable public to be reused in other packages Signed-off-by: Silvio Moioli <[email protected]> * Let lasso know whether a type is watchable upon requesting a cache Signed-off-by: Silvio Moioli <[email protected]> * Adapt existing tests Signed-off-by: Silvio Moioli <[email protected]> * Add a test to check watchability is detected correctly Signed-off-by: Silvio Moioli <[email protected]> --------- Signed-off-by: Silvio Moioli <[email protected]>
d04ecd8
to
f63f2ae
Compare
The branch here should be release/v0.3 according to https://github.com/rancher/steve/blob/main/VERSION.md. We'll be deleting the older branches later, after we fully transition. |
Base changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about kubernetes version bump and another about Vai in lasso.
c8d73fa
to
67e3385
Compare
Signed-off-by: Silvio Moioli <[email protected]>
67e3385
to
adf7a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change but otherwise looks good
Co-authored-by: Tom Lebreux <[email protected]>
* Update indexed fields * Add .status.currentReplicas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I got caught up on the target branch -- the sooner we can align all the release branch names the better.
This backports #400, #430, #284, #433
#284 needed some minor adaptation, mostly due to the different mocking framework
I hope this helps