SQLite backed cache: indexed fields round #4 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/issues/48256wq Signed-off-by: Silvio Moioli <[email protected]>
Note this is already in main: steve/pkg/stores/sqlproxy/proxy_store.go Line 101 in 6512945 Should it be removed? Current PR leaves it alone. |
richard-cox
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
gvkKey("storage.k8s.io", "v1", "StorageClass"): {
{"provisioner"},
{"metadata", "annotations[storageclass.kubernetes.io/is-default-class]"},
},
Looks good. Apologies i think i'd originally requested just annotations[storageclass.kubernetes.io/is-default-class] (and set in UI), so the request for change was to ensure the correct value was in, which it already was. As per discussion it looks like the field isn't indexed, but will progress that issue once rancher/lasso#120 has merged
richard-cox
reviewed
Dec 18, 2024
tomleb
approved these changes
Dec 18, 2024
crobby
approved these changes
Dec 19, 2024
moio
added a commit
to moio/steve
that referenced
this pull request
Dec 20, 2024
* Change indexed fields according to https://github.com/rancher/rancher/issues/48256wq Signed-off-by: Silvio Moioli <[email protected]> * Fix typo --------- Signed-off-by: Silvio Moioli <[email protected]>
moio
added a commit
to moio/steve
that referenced
this pull request
Jan 9, 2025
* Change indexed fields according to https://github.com/rancher/rancher/issues/48256wq Signed-off-by: Silvio Moioli <[email protected]> * Fix typo --------- Signed-off-by: Silvio Moioli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rancher/rancher#48256