Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new label select filtering #12919

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Integrate new label select filtering #12919

wants to merge 8 commits into from
+863 −255

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Dec 19, 2024 •
edited
Loading

Blocked on

Summary

Contributes to #10417

Occurred changes and/or fixed issues

  • Wired in to
    • Workload detail page - pods and services (broken due to reverse selector)
    • Service Detail - Pods List
    • Service create/edit - Pod selector tab
  • Also
    • Fix showPodRestarts in random location

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox
Test / Wire in new label filtering to limited places
f905fa1 
- Wired in to
  - Workload detail page - pods and services (broken due to reverse selector)
  - Service Detail - Pods List
  - Service create/edit - Pod selector tab
- Also
  - Fix showPodRestarts in random location
- TODOs
  - Lots of testing / validation required
  - reverse deployment --> service selector (not services given deployment, but for each service contains pods from deployment)
  - workload model usages of pods getter
  - services model usages of pods getter
  - many many more....
@richard-cox richard-cox added the ci/skip-e2e Forcibly skip E2E tests in the CI label Dec 19, 2024
@richard-cox richard-cox added this to the v2.11.0 milestone Dec 19, 2024
@richard-cox richard-cox self-assigned this Dec 19, 2024
@richard-cox richard-cox marked this pull request as draft January 2, 2025 14:39
@richard-cox richard-cox force-pushed the pagination-label-select branch from a6698cb to e7a812a Compare January 31, 2025 12:59
@richard-cox richard-cox force-pushed the pagination-label-select branch from bfd382e to df2a4db Compare February 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@richard-cox richard-cox

Labels
ci/skip-e2e Forcibly skip E2E tests in the CI
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@richard-cox