Application of selectors locally scales badly
#10417
Assignees
Labels
Milestone
Comments
50 tasks
richard-cox
added a commit
to richard-cox/dashboard
that referenced
this issue
May 28, 2024
richard-cox
added a commit
to richard-cox/dashboard
that referenced
this issue
May 29, 2024
7 tasks
richard-cox
added a commit
that referenced
this issue
Jun 11, 2024
* Changes for new design - New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts * Changes following review * Update Node list to support server-side pagination - Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes * Lint / test / fixes * Improvements to configmap e2e test & Improve pagination disabled * Beef up validation * Fix missing name column in non-server-side paginated node list * Fix PR automation actions - fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see #10534 * CI bump * Fixes post merge * Wire in 2.9.0 settings for server-side pagination - Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings * Integrate pagination with configmaps in cis clusterscanbenchmark edit form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled * - harvester machine-config - project monitoring (and bug fixes) * Disable workload screen if vai cache is on - temp step until we get new overview * TODOs and TEST * Conditionally remove fetch of all secrets from SelectOrCreateAuthSecret * TODOs and TEST * Update SimpleSecretSelector - only used in monitoring.coreos.com.alertmanagerconfig context * View and Edit ingress - secrets * node detail page - pods list * Backup/Restore: Secrets (WIP) * Backup/Restore: Secrets, and other usages of SimpleSecretSelector / SelectOrCreateAuthSecret * Edit: Service account * Add comments for remaining items * Paginate Secret selection for logging providers - Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response * WIP * fixes arfter merge * Don't suggest container names, not practical - previously all pods were fetched... and we scrapped all container names from them - this is a scaling nightmare, user now must just enter the name/s to match * Avoid findAll secrets in SimpleSecretSelector * tidying up * Move LabeledSelect/index.vue back to LabeledSelect.vue to not break extensions * changes after self review... 1 * changes after self review... 2 * ooof * changes after self review... 3 * fix formatting * Link new paginated label select with pagination setting * Work around failing kubewarden unit tests in check-plugins gate * Fix backup.spec e2e test * fix formatting, paginationUtils.isSteveCacheEnabled --> paginationUtils.isEnabled * Don't fetch all secrets on cloud creds page * Fix backup.spec e2e test * TODO tidying / tracking * don't getch ALL workloads for hacky way to get a link to a service's workload * Fix bad merge * Updates after working with vai cache image * test fixes * Create a convienence wrapper called ResourceLabelSelector that hides most of the complexity * fix unit test * Updates following review * Remove workload health until #10417 is resolved * Updates following review * changes following self review * Fix bottom bar of edit backup, edit restore pages * revert temp change * changes following self review * Workaround for kubewarden unit tests in check plugin gate * bump * Fix e2e * Fix linting * type fixing * - improve filtering without pagination - update allowed fields given latest backend changes - enable on by default exact filter string matches (disable for lists * remove temp code * fix linting * Changes following review * Fixes for vai cache feature flag - name was changed from on-disk-steve-cache to ui-sql-cache - fix timing issue - don't watch resources until we know the vai cache feature flag * Changes following review * Fix two sketchy tests - new exception in docs page - don't nav to page via button click and then goto same page * More test improvement - force user to go to tab which is source of route guard issue - move setup stuff to a test for cypress to re-retry
richard-cox
added a commit
that referenced
this issue
Jun 11, 2024
…ginated (#11129) * Changes for new design - New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts * Changes following review * Update Node list to support server-side pagination - Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes * Lint / test / fixes * Improvements to configmap e2e test & Improve pagination disabled * Beef up validation * Fix missing name column in non-server-side paginated node list * Fix PR automation actions - fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see #10534 * CI bump * Fixes post merge * Wire in 2.9.0 settings for server-side pagination - Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings * Integrate pagination with configmaps in cis clusterscanbenchmark edit form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled * - harvester machine-config - project monitoring (and bug fixes) * Disable workload screen if vai cache is on - temp step until we get new overview * TODOs and TEST * Conditionally remove fetch of all secrets from SelectOrCreateAuthSecret * TODOs and TEST * Update SimpleSecretSelector - only used in monitoring.coreos.com.alertmanagerconfig context * View and Edit ingress - secrets * node detail page - pods list * Backup/Restore: Secrets (WIP) * Backup/Restore: Secrets, and other usages of SimpleSecretSelector / SelectOrCreateAuthSecret * Edit: Service account * Add comments for remaining items * Paginate Secret selection for logging providers - Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response * WIP * fixes arfter merge * Don't suggest container names, not practical - previously all pods were fetched... and we scrapped all container names from them - this is a scaling nightmare, user now must just enter the name/s to match * Avoid findAll secrets in SimpleSecretSelector * tidying up * Move LabeledSelect/index.vue back to LabeledSelect.vue to not break extensions * changes after self review... 1 * changes after self review... 2 * ooof * changes after self review... 3 * fix formatting * Link new paginated label select with pagination setting * Work around failing kubewarden unit tests in check-plugins gate * Fix backup.spec e2e test * fix formatting, paginationUtils.isSteveCacheEnabled --> paginationUtils.isEnabled * Don't fetch all secrets on cloud creds page * Fix backup.spec e2e test * TODO tidying / tracking * don't getch ALL workloads for hacky way to get a link to a service's workload * Fix bad merge * Updates after working with vai cache image * test fixes * Create a convienence wrapper called ResourceLabelSelector that hides most of the complexity * fix unit test * Add alt-loading indicator to sortable table, use for pagination * Updates following review * Remove workload health until #10417 is resolved * Updates following review * changes following self review * Fix bottom bar of edit backup, edit restore pages * revert temp change * changes following self review * Workaround for kubewarden unit tests in check plugin gate * bump * Fix e2e * Fix linting * type fixing * fix standard loading indicator * - improve filtering without pagination - update allowed fields given latest backend changes - enable on by default exact filter string matches (disable for lists * remove temp code * fix linting * Changes following review * Fixes for vai cache feature flag - name was changed from on-disk-steve-cache to ui-sql-cache - fix timing issue - don't watch resources until we know the vai cache feature flag * Changes following review * Fix two sketchy tests - new exception in docs page - don't nav to page via button click and then goto same page * More test improvement - force user to go to tab which is source of route guard issue - move setup stuff to a test for cypress to re-retry * changes following review
|
Implementation dependent on rancher/rancher#46333 |
|
See rancher/rancher#46333 (comment) More complex / full labelSelector support will not be included in 2.10 and are out of scope of the above linked issue. For this release we will disable the basic use cases of If more core use cases are discovered then the above can be reviewed Edit: More use cases have been discovered (description updated) |
|
@moio I've updated the issue including all the places where we apply fully selectors locally. There's quite a few. There's a lot of work there to either
|
|
@richard-cox: I agree this list looks too long to accept in a non-experimental version. Disabling them while the feature is experimental does not make sense to me. Better to have a list of known regressions (or a shortlist of features expected to work) and actually address the underlying limitations. I am adding full label selector API support to rancher/rancher#46333. |
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this issue
Oct 24, 2024
* Changes for new design - New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts * Changes following review * Update Node list to support server-side pagination - Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes * Lint / test / fixes * Improvements to configmap e2e test & Improve pagination disabled * Beef up validation * Fix missing name column in non-server-side paginated node list * Fix PR automation actions - fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534 * CI bump * Fixes post merge * Wire in 2.9.0 settings for server-side pagination - Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings * Integrate pagination with configmaps in cis clusterscanbenchmark edit form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled * - harvester machine-config - project monitoring (and bug fixes) * Disable workload screen if vai cache is on - temp step until we get new overview * TODOs and TEST * Conditionally remove fetch of all secrets from SelectOrCreateAuthSecret * TODOs and TEST * Update SimpleSecretSelector - only used in monitoring.coreos.com.alertmanagerconfig context * View and Edit ingress - secrets * node detail page - pods list * Backup/Restore: Secrets (WIP) * Backup/Restore: Secrets, and other usages of SimpleSecretSelector / SelectOrCreateAuthSecret * Edit: Service account * Add comments for remaining items * Paginate Secret selection for logging providers - Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response * WIP * fixes arfter merge * Don't suggest container names, not practical - previously all pods were fetched... and we scrapped all container names from them - this is a scaling nightmare, user now must just enter the name/s to match * Avoid findAll secrets in SimpleSecretSelector * tidying up * Move LabeledSelect/index.vue back to LabeledSelect.vue to not break extensions * changes after self review... 1 * changes after self review... 2 * ooof * changes after self review... 3 * fix formatting * Link new paginated label select with pagination setting * Work around failing kubewarden unit tests in check-plugins gate * Fix backup.spec e2e test * fix formatting, paginationUtils.isSteveCacheEnabled --> paginationUtils.isEnabled * Don't fetch all secrets on cloud creds page * Fix backup.spec e2e test * TODO tidying / tracking * don't getch ALL workloads for hacky way to get a link to a service's workload * Fix bad merge * Updates after working with vai cache image * test fixes * Create a convienence wrapper called ResourceLabelSelector that hides most of the complexity * fix unit test * Updates following review * Remove workload health until rancher#10417 is resolved * Updates following review * changes following self review * Fix bottom bar of edit backup, edit restore pages * revert temp change * changes following self review * Workaround for kubewarden unit tests in check plugin gate * bump * Fix e2e * Fix linting * type fixing * - improve filtering without pagination - update allowed fields given latest backend changes - enable on by default exact filter string matches (disable for lists * remove temp code * fix linting * Changes following review * Fixes for vai cache feature flag - name was changed from on-disk-steve-cache to ui-sql-cache - fix timing issue - don't watch resources until we know the vai cache feature flag * Changes following review * Fix two sketchy tests - new exception in docs page - don't nav to page via button click and then goto same page * More test improvement - force user to go to tab which is source of route guard issue - move setup stuff to a test for cypress to re-retry
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this issue
Oct 24, 2024
…ginated (rancher#11129) * Changes for new design - New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts * Changes following review * Update Node list to support server-side pagination - Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes * Lint / test / fixes * Improvements to configmap e2e test & Improve pagination disabled * Beef up validation * Fix missing name column in non-server-side paginated node list * Fix PR automation actions - fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534 * CI bump * Fixes post merge * Wire in 2.9.0 settings for server-side pagination - Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings * Integrate pagination with configmaps in cis clusterscanbenchmark edit form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled * - harvester machine-config - project monitoring (and bug fixes) * Disable workload screen if vai cache is on - temp step until we get new overview * TODOs and TEST * Conditionally remove fetch of all secrets from SelectOrCreateAuthSecret * TODOs and TEST * Update SimpleSecretSelector - only used in monitoring.coreos.com.alertmanagerconfig context * View and Edit ingress - secrets * node detail page - pods list * Backup/Restore: Secrets (WIP) * Backup/Restore: Secrets, and other usages of SimpleSecretSelector / SelectOrCreateAuthSecret * Edit: Service account * Add comments for remaining items * Paginate Secret selection for logging providers - Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response * WIP * fixes arfter merge * Don't suggest container names, not practical - previously all pods were fetched... and we scrapped all container names from them - this is a scaling nightmare, user now must just enter the name/s to match * Avoid findAll secrets in SimpleSecretSelector * tidying up * Move LabeledSelect/index.vue back to LabeledSelect.vue to not break extensions * changes after self review... 1 * changes after self review... 2 * ooof * changes after self review... 3 * fix formatting * Link new paginated label select with pagination setting * Work around failing kubewarden unit tests in check-plugins gate * Fix backup.spec e2e test * fix formatting, paginationUtils.isSteveCacheEnabled --> paginationUtils.isEnabled * Don't fetch all secrets on cloud creds page * Fix backup.spec e2e test * TODO tidying / tracking * don't getch ALL workloads for hacky way to get a link to a service's workload * Fix bad merge * Updates after working with vai cache image * test fixes * Create a convienence wrapper called ResourceLabelSelector that hides most of the complexity * fix unit test * Add alt-loading indicator to sortable table, use for pagination * Updates following review * Remove workload health until rancher#10417 is resolved * Updates following review * changes following self review * Fix bottom bar of edit backup, edit restore pages * revert temp change * changes following self review * Workaround for kubewarden unit tests in check plugin gate * bump * Fix e2e * Fix linting * type fixing * fix standard loading indicator * - improve filtering without pagination - update allowed fields given latest backend changes - enable on by default exact filter string matches (disable for lists * remove temp code * fix linting * Changes following review * Fixes for vai cache feature flag - name was changed from on-disk-steve-cache to ui-sql-cache - fix timing issue - don't watch resources until we know the vai cache feature flag * Changes following review * Fix two sketchy tests - new exception in docs page - don't nav to page via button click and then goto same page * More test improvement - force user to go to tab which is source of route guard issue - move setup stuff to a test for cypress to re-retry * changes following review
7 tasks
|
We should be able to get back workload health indicators once this work is complete (see shell/list/workload.vue loadHeathResources) |
|
Note - some affected places in code now reference this issue. ensure those are addressed when resolving this |
This was referenced Jan 9, 2025
|
Blocked on rancher/rancher#46333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocked on rancher/rancher#46333
labelSelectorfilter=metadata.labelinsteadmatchinggetter --> selector.js matchingUseful links
Notes
Edit: Updates with all cases
The text was updated successfully, but these errors were encountered: