View button (#718) #758
Merged
View button (#718) #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoelBiju
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 98.25% 98.43% +0.17%
==========================================
Files 114 114
Lines 5668 5673 +5
Branches 1448 1449 +1
==========================================
+ Hits 5569 5584 +15
+ Misses 94 84 -10
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
GoelBiju
changed the title
Due to more data mismatch issues as documented in #718, certain e2e tests relying on testing data by file size need to be skipped. They have been marked with an appropriate comment so they can be found later. Also fixing a test for loading more rows which was failing because an element could not be located on the DOM. In reality, it was there but was not directly visible - it had to be scrolled down to for it to be detected.
3 tasks
This was due to a before each hook failing
…acilities/datagateway into feature/toggle-button-#718
sam-glendenning
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the toggle for card/table view into a button in accordance with #718. Adds a button with the "Display as cards" or "Display as table" labels depending on the view you are in.
Testing instructions
Agile board tracking
Closes #718