-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change toggle button to a button with different labels "Display as cards" / "Display as table" #718
Comments
@agbeltran @louise-davies @sam-glendenning @MRichards99 I have changed the design of the toggle switch to be a button instead. This is what it looks like presently: A few questions about the design might need to be discussed:
|
Just continuing with this design for now and adding some small padding produces a view like this: The other idea suggested by @louise-davies was to have the icon and the label separate. Possibly with the label to the left of a separate icon which you can click. |
I've forgotten some of the suggestions from the last sprint review but was the length of the button/label an issue we raised? If so, could change the label to say "Card view" / "Table view" Saying that I don't mind the look of the above screenshot! Worth presenting once again at the next sprint review for everyone's thoughts on the new design |
That's a good idea, the length was one thing we mentioned. We could for something shorter like what you mentioned. I was initially thinking of changing the design but having it with the correct padding makes it look better now. |
Ah yeah, I meant to illustate a mock up - my bad! I thought perhaps something like this: https://codesandbox.io/s/button-demo-3l8t4?file=/demo.js |
Thanks @louise-davies for the example! I was looking as to how to center the |
Due to more data mismatch issues as documented in #718, certain e2e tests relying on testing data by file size need to be skipped. They have been marked with an appropriate comment so they can be found later. Also fixing a test for loading more rows which was failing because an element could not be located on the DOM. In reality, it was there but was not directly visible - it had to be scrolled down to for it to be detected.
This was due to a before each hook failing
Description:
Currently, it seems that the default label is "Toggle cards" which we agreed that is not the best phrasing. We agreed on changing it to a button whose label will change between "Displays as cards" and "Display as table".
Acceptance criteria:
The text was updated successfully, but these errors were encountered: