Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toggle button to a button with different labels "Display as cards" / "Display as table" #718

Closed
1 task done
agbeltran opened this issue Jun 8, 2021 · 6 comments · Fixed by #758
Closed
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@agbeltran
Copy link
Member

agbeltran commented Jun 8, 2021

Description:
Currently, it seems that the default label is "Toggle cards" which we agreed that is not the best phrasing. We agreed on changing it to a button whose label will change between "Displays as cards" and "Display as table".

Acceptance criteria:

  • Change toggle button for cards/table view
@agbeltran agbeltran added the enhancement New feature or request label Jun 8, 2021
@agbeltran agbeltran changed the title Change default label for cards as "Display as cards" Change toggle button to a button with different labels "Display as cards" / "Display as table" Jun 8, 2021
@GoelBiju GoelBiju self-assigned this Jul 20, 2021
@GoelBiju GoelBiju mentioned this issue Jul 20, 2021
3 tasks
GoelBiju added a commit that referenced this issue Jul 22, 2021
@GoelBiju
Copy link
Contributor

@agbeltran @louise-davies @sam-glendenning @MRichards99 I have changed the design of the toggle switch to be a button instead. This is what it looks like presently:

  • "Display as tables":
    image

  • "Display as cards":
    image

A few questions about the design might need to be discussed:

  • The colour of the button?
  • Does the button shape and look appropriate?
  • Are the icons on the button appropriate?
  • Where should the placement of the button be? (Should it remain in the same place as the toggle?)

@GoelBiju
Copy link
Contributor

@agbeltran @louise-davies @sam-glendenning @MRichards99 I have changed the design of the toggle switch to be a button instead. This is what it looks like presently:

  • "Display as tables":
    image
  • "Display as cards":
    image

A few questions about the design might need to be discussed:

  • The colour of the button?
  • Does the button shape and look appropriate?
  • Are the icons on the button appropriate?
  • Where should the placement of the button be? (Should it remain in the same place as the toggle?)

Just continuing with this design for now and adding some small padding produces a view like this:

image

The other idea suggested by @louise-davies was to have the icon and the label separate. Possibly with the label to the left of a separate icon which you can click.

@sam-glendenning
Copy link
Contributor

I've forgotten some of the suggestions from the last sprint review but was the length of the button/label an issue we raised? If so, could change the label to say "Card view" / "Table view"

Saying that I don't mind the look of the above screenshot! Worth presenting once again at the next sprint review for everyone's thoughts on the new design

@GoelBiju
Copy link
Contributor

I've forgotten some of the suggestions from the last sprint review but was the length of the button/label an issue we raised? If so, could change the label to say "Card view" / "Table view"

Saying that I don't mind the look of the above screenshot! Worth presenting once again at the next sprint review for everyone's thoughts on the new design

That's a good idea, the length was one thing we mentioned. We could for something shorter like what you mentioned. I was initially thinking of changing the design but having it with the correct padding makes it look better now.

@louise-davies
Copy link
Member

Ah yeah, I meant to illustate a mock up - my bad! I thought perhaps something like this: https://codesandbox.io/s/button-demo-3l8t4?file=/demo.js

@GoelBiju
Copy link
Contributor

Ah yeah, I meant to illustate a mock up - my bad! I thought perhaps something like this: https://codesandbox.io/s/button-demo-3l8t4?file=/demo.js

Thanks @louise-davies for the example! I was looking as to how to center the IconButton with the text. We can maybe come to a decision as to which design in future meetings.

GoelBiju added a commit that referenced this issue Jul 29, 2021
sam-glendenning pushed a commit that referenced this issue Aug 4, 2021
Due to more data mismatch issues as documented in #718, certain e2e tests relying on testing data by file size need to be skipped. They have been marked with an appropriate comment so they can be found later.

Also fixing a test for loading more rows which was failing because an element could not be located on the DOM. In reality, it was there but was not directly visible - it had to be scrolled down to for it to be detected.
sam-glendenning pushed a commit that referenced this issue Aug 4, 2021
This was due to a before each hook failing
GoelBiju added a commit that referenced this issue Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants