Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements/deps upgrade raiden-contracts #5086

Closed

Conversation

pirapira
Copy link
Contributor

So raiden-contracts=0.33.0 is used.

Fixes: #

Description

Please, describe what this PR does in detail:

  • If it's a new feature, describe the feature this PR is introducing and design decisions.

After this PR, raiden-contracts 0.33.0 will be used.

PR review check list

Quality check list that cannot be automatically verified.

  • Safety
  • Code quality
    • Error conditions are handled
    • Exceptions are propagated to the correct parent greenlet
    • Exceptions are correctly classified as recoverable or unrecoverable
  • Compatibility
    • State changes are forward compatible
    • Transport messages are backwards and forward compatible
  • Commits
    • Have good messages
    • Squashed unecessary commits
  • If it's a bug fix:
    • Regression test for the bug
      • Properly covers the bug
      • If an integration test is used, it could not be written as a unit test
  • Documentation
    • A new CLI flag was introduced, is there documentation that explains usage?
  • Specs
    • If this is a protocol change, are the specs updated accordingly? If so, please link PR from the specs repo.
  • Is it a user facing feature/bug fix?
    • Changelog entry has been added

So raiden-contracts=0.33.0 is used.
because mainnet deployments already exist.
@pirapira
Copy link
Contributor Author

0.33.0 is somehow broken raiden-network/raiden-contracts#1288.

@pirapira pirapira closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant