Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new file in MANIFEST #1288

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

pirapira
Copy link
Contributor

What this PR does

This PR adds one line in MANIFEST.in

Why I'm making this PR

I saw a file missing in the PyPI package

What's tricky about this PR (if any)

It was a bit tricky to figuring out why the file was missing.


Any reviewer can check these:

  • If the PR is fixing a bug or adding a feature, add an entry to CHANGELOG.md.
  • If the PR changed a Solidity source, run make compile_contracts and add the resulting raiden_contracts/data/contracts.json in the PR.
  • If the PR is changing documentation only, add [skip ci] in the commit message so Travis does not waste time.
    • But, if the PR changes comments in a Solidity source, do not add [skip ci] and let Travis check the hash of the source.
  • In Python, use keyword arguments
  • Squash unnecessary commits
  • Comment commits
  • Follow naming conventions
    • solidityFunction
    • _solidity_argument
    • solidity_variable
    • python_variable
    • PYTHON_CONSTANT
  • Follow the Signature Convention in CONTRIBUTING.md
  • For each new contract
    • The deployment script deploys the new contract.
    • etherscan_verify.py runs on the new contract.
  • Bookkeep
    • The gas cost of new functions are stored in gas.json.
  • Solidity specific conventions
    • Document arguments of functions in natspec
    • Care reentrancy problems
    • if the PR adds or removes require() or assert()
      • add an entry in Changelog
      • open an issue in the client, light client, service repos so the change is reflected there
      • Just adding a message in require() doesn't require these steps.
  • When you catch a require() failure in Solidity, look for a specific error message like pytest.raises(TransactionFailed, match="error message"):

And before "merge" all checkboxes have to be checked. If you find redundant points, remove them.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1288   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files          21       21           
  Lines        1456     1456           
  Branches      190      190           
=======================================
  Hits         1189     1189           
  Misses        228      228           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe4447...9cdee78. Read the comment docs.

@pirapira pirapira requested a review from kelsos October 15, 2019 08:13
@pirapira pirapira merged commit c67cbca into raiden-network:master Oct 15, 2019
@pirapira pirapira deleted the include-mainnet-service branch October 15, 2019 11:23
@pirapira pirapira mentioned this pull request Oct 15, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants