Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split store_and_verify_deployment_info_services() #896

Merged
merged 5 commits into from
May 2, 2019
Merged

Split store_and_verify_deployment_info_services() #896

merged 5 commits into from
May 2, 2019

Conversation

pirapira
Copy link
Contributor

because this function took a boolean and did two completely different things depending on the boolean.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #896 into master will decrease coverage by 0.05%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files          20       20              
  Lines        1276     1272       -4     
  Branches      147      145       -2     
==========================================
- Hits         1066     1062       -4     
  Misses        178      178              
  Partials       32       32
Impacted Files Coverage Δ
raiden_contracts/deploy/contract_verifyer.py 98.07% <81.81%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9b01d...b81fb18. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #896 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #896     +/-   ##
=========================================
+ Coverage   83.54%   83.64%   +0.1%     
=========================================
  Files          20       20             
  Lines        1276     1272      -4     
  Branches      147      145      -2     
=========================================
- Hits         1066     1064      -2     
  Misses        178      178             
+ Partials       32       30      -2
Impacted Files Coverage Δ
raiden_contracts/deploy/contract_verifier.py 100% <100%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e72a9...493b436. Read the comment docs.

@pirapira
Copy link
Contributor Author

Codecov is complaining. I'll write more tests to cover the diff https://codecov.io/gh/raiden-network/raiden-contracts/compare/2d9b01dac737442607bbcbfbff732cb7e409b02b...b81fb182d850dd2b7a7821a15b92f0127233f6a3/diff#D2-54.

@pirapira pirapira force-pushed the split_store_and_verify branch from b81fb18 to 5485c6b Compare April 29, 2019 10:04
@pirapira pirapira force-pushed the split_store_and_verify branch from 5485c6b to 493b436 Compare April 30, 2019 11:46
@pirapira pirapira requested a review from rakanalh May 2, 2019 09:23
@pirapira
Copy link
Contributor Author

pirapira commented May 2, 2019

Thank you!

@pirapira pirapira merged commit 7240b2c into raiden-network:master May 2, 2019
@pirapira pirapira deleted the split_store_and_verify branch May 2, 2019 09:57
@pirapira pirapira mentioned this pull request May 2, 2019
Closed
pirapira added a commit to pirapira/raiden-contracts that referenced this pull request May 2, 2019
@pirapira
Fix how to call verify_contracts_deployment_data
0c3d6ae 
This is a leftover of raiden-network#896.  Some function signatures changed there
but not all calling sites adapted.
pirapira added a commit to pirapira/raiden-contracts that referenced this pull request May 2, 2019
@pirapira
Fix how to call verify_contracts_deployment_data
62635c7 
This is a leftover of raiden-network#896.  Some function signatures changed there
but not all calling sites were updated accordingly.
@pirapira pirapira mentioned this pull request May 2, 2019
Merged
pirapira added a commit to pirapira/raiden-contracts that referenced this pull request May 3, 2019
@pirapira
Fix how to call verify_contracts_deployment_data
37abc14 
This is a leftover of raiden-network#896.  Some function signatures changed there
but not all calling sites were updated accordingly.
rakanalh pushed a commit that referenced this pull request May 6, 2019
@pirapira @rakanalh
Fix how to call verify_contracts_deployment_data
d612266 
This is a leftover of #896.  Some function signatures changed there
but not all calling sites were updated accordingly.
@pirapira pirapira mentioned this pull request Sep 3, 2019
Closed
@pirapira pirapira mentioned this pull request Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh rakanalh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirapira @rakanalh