Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split store_and_verify_deployment_info_raiden() into two functions one that stores and the other that doesn't #885

Closed
pirapira opened this issue Apr 23, 2019 · 2 comments
Closed

Split store_and_verify_deployment_info_raiden() into two functions one that stores and the other that doesn't #885

pirapira opened this issue Apr 23, 2019 · 2 comments
Labels
efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever refactoring

Comments

@pirapira
Copy link
Contributor

ContractVerifyer.store_and_verify_deployment_info_raiden() takes a boolean argument and behaves one of the two ways accordingly. This issue keeps track of splitting this function into two, each corresponding to calling store_and_verify_deployment_info_raiden() with save_info=True and save_info=False.
@pirapira pirapira added refactoring P1 urgent, blocker, or makes life easier forever efforts: low_hanging_fruit labels Apr 26, 2019
@pirapira
Copy link
Contributor Author

The same should be done at the same time to store_and_verify_deployment_info_services().

@pirapira
Copy link
Contributor Author

pirapira commented May 2, 2019

This has been done in #896.

@pirapira pirapira closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirapira