Document gas measuring for releasing #508
Conversation
|
|
||
| pytest -s raiden_contracts/tests/test_print_gas.py | ||
|
|
||
| The script prints many numbers like |
There was a problem hiding this comment.
@pirapira Wouldn't it make more sense to remake the script into measure_gas.py and have it auto-generate the constants.py for you instead of you manually creating by copying the output of the script?
|
I don't think this should have been merged, the gas cost will change with the version of the smart contract, so this data should go into the json (which has the additional benefit of working with other languages, besides python) |
|
@hackaugusto That's also a nice idea -- but perhaps going for other language other than python may be a premature optimization at the moment. But according to @pirapira 's comment above I understand that what this PR documents is temporary and the "real thing" approach is discussed and documented in this issue |
|
@hackaugusto I do document the current ugly approach before changing it. |
This fixes #492.
[no ci] <-- seems not working #507