-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create script to save transaction gas cost estimations to doc #16
Comments
Update: the values should not be in the docs, but as package deliverables. We can make this script run at deployment time for the testnet and save the addresses & gas estimation values together, in a json file. Related: #306 |
This should have not been closed, sorry. #335 only adds the gas limits to the |
An idea mentioned by @hackaugusto here is to not auto-generate a |
|
|
Here is one option:
|
But, the first task is probably #547 . After that the test can be turned into a script. |
This issue is about adding the gas information in the document. I don't know if that's so urgent. |
tl;dr
Gas cost estimations are calculated in
test_print_gas.py
. This should not be ran as a test, but should be a script that generates a file with the information, which should be added in the docs.Problem Definition
There is no way for (advanced developer) users to easily see a rundown of how much it would cost at any verion of raiden to perform common channel operations.
Solution
Add a table, probably in spec.rst with gas costs of all raiden common channel operations which should be updated every time we change the logic of the contracts or if there is any considerable contract revamp.
This way we will be able to efficiently have a versioned tracking of gas costs optimizations and also a way to identify bottlenecks that require optimization.
The text was updated successfully, but these errors were encountered: