Update cloud functional test workflow - fix for (reading 'id')

[lakshmimsft]

Description

As reported in #7782, #7668, attempting to stop functional test runs upon 'workflow_run' against main.
Manual workflow-dispatch for cloud tests works without errors on main branch and scheduled runs do not produce this error. Will run test runs to determine correct fix.

Type of change

• This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7782, #7668

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	7f9fa9c
Unique ID	func65e6c6e422
Image tag	pr-func65e6c6e422

Click here to see the list of tools in the current test run

• gotestsum 1.12.0
• KinD: v0.20.0
• Dapr: 1.12.0
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func65e6c6e422
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func65e6c6e422
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func65e6c6e422
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func65e6c6e422
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.06%. Comparing base (33d3d5e) to head (3c9fec5).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7822      +/-   ##
==========================================
- Coverage   61.07%   61.06%   -0.01%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
- Hits        16774    16772       -2     
- Misses       9209     9210       +1     
- Partials     1483     1484       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ytimocin]

Could you explain this attempting to stop functional test runs upon 'workflow_run' against main a little bit more? I didn't know that that was the problem.

[lakshmimsft]

In all 'expected' usecases , the workflow is running without errors. Based on error, the issue seems to be when the tests are run with github.event_name 'workflow_run' and run on branch main/ not on the PR branch, that is why there is no pr/id.

[lakshmimsft]

Discussed offline. We confirmed the functional tests are not getting triggered upon PR merge into main.
The specific errors are not occuring since the split into cloud/non-cloud tests.
Closing this PR and related issues.