Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'id') in functional-test-cloud workflow in main #7782

Closed
1 task
ytimocin opened this issue Aug 2, 2024 · 3 comments · Fixed by #7907
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged

Comments

@ytimocin
Copy link
Contributor

ytimocin commented Aug 2, 2024

Steps to reproduce

In main branch, when the functional-test-cloud workflow runs, we get this error: TypeError: Cannot read properties of undefined (reading 'id').

Here is an example workflow: https://github.com/radius-project/radius/actions/runs/10220061614/job/28279647756.

Observed behavior

functional-test-cloud workflow fails on main.

Desired behavior

functional-test-cloud workflow runs successfully on main.

Workaround

No response

rad Version

edge

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12933

@ytimocin ytimocin added the bug Something is broken or not working as expected label Aug 2, 2024
@radius-triage-bot
Copy link

👋 @ytimocin Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

Copy link

azure-boards bot commented Aug 2, 2024

✅ Successfully linked to Azure Boards work item(s):

@nicolejms nicolejms added the triaged This issue has been reviewed and triaged label Aug 22, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

lakshmimsft added a commit that referenced this issue Sep 5, 2024
# Description

There have been some unexpected runs for the cloud-functional-tests
which fail. A recent instance was on 9/1/2024, with multiple runs, some
of which were against commits that were already merged into main 2 days
ago.
eg. https://github.com/radius-project/radius/actions/runs/10648348010

This PR adds additional logging to capture the values of multiple
fields, allowing us to determine the correct filter conditions for
triggering the workflow when event = workflow_run.

Note: This specific event may also have been related to a GitHub outage
that happened the same week but nonetheless, similar failed runs have
been recorded earlier.

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
#7782

Fixes: Gets more data for #7782
ytimocin pushed a commit that referenced this issue Sep 6, 2024
# Description

There have been some unexpected failed runs for the
cloud-functional-tests #7782.
Earlier PR #7885 added
debug logs which have given some useful data.
This PR adds to these debug logs to help debug further.

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
#7782

Fixes: Gets more data for #7782
ytimocin pushed a commit that referenced this issue Sep 9, 2024
# Description

Ref: #7892
Based on logs seen for errors in the past week,
eg.
https://github.com/radius-project/radius/actions/runs/10753879482/job/29823820614

Adding condition to workflow to run when
github.event.workflow_run.conclusion == 'success' when event is
workflow_run.
Keeping additional debug logs in place for the next few days to monitor
any subsequent failures.
Another PR to remove logs will be sent closer to end of this week if no
failures are detected.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(#7782).

Fixes: #7782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged
Projects
None yet
2 participants