Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the deps in package-lock.json for typespec #7815

Closed
wants to merge 1 commit into from

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Aug 15, 2024

Description

Updating the deps in package-lock.json for typespec

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7812

@ytimocin ytimocin requested review from a team as code owners August 15, 2024 21:47
@ytimocin ytimocin temporarily deployed to functional-tests August 15, 2024 21:47 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 15, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 3c474b0
Unique ID func96c6d710f1
Image tag pr-func96c6d710f1
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func96c6d710f1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func96c6d710f1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func96c6d710f1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func96c6d710f1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

github-actions bot commented Aug 15, 2024

Unit Tests

3 299 tests  ±0   3 293 ✅ ±0   3m 53s ⏱️ -4s
  263 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 1454a63. ± Comparison against base commit 7da87d4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (7da87d4) to head (1454a63).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7815      +/-   ##
==========================================
+ Coverage   61.05%   61.07%   +0.02%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
+ Hits        16768    16776       +8     
+ Misses       9212     9208       -4     
+ Partials     1486     1482       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What triggering this change? How did we detect this?

@kachawla
Copy link
Contributor

kachawla commented Aug 16, 2024

What triggering this change? How did we detect this?

I think this is answered in #7812. Let's please add this issue in the description to helpful everyone get relevant context.

@ytimocin ytimocin force-pushed the ytimocin/typespec/depUpdate branch from 3c474b0 to 63fa3ae Compare August 21, 2024 17:28
@ytimocin ytimocin temporarily deployed to functional-tests August 21, 2024 17:28 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 21, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 63fa3ae
Unique ID func867a4da24f
Image tag pr-func867a4da24f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func867a4da24f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func867a4da24f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func867a4da24f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func867a4da24f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

@ytimocin ytimocin force-pushed the ytimocin/typespec/depUpdate branch from 63fa3ae to 0522455 Compare August 24, 2024 00:40
@ytimocin ytimocin force-pushed the ytimocin/typespec/depUpdate branch from 0522455 to 1454a63 Compare August 27, 2024 05:03
@ytimocin ytimocin closed this Sep 5, 2024
@ytimocin ytimocin deleted the ytimocin/typespec/depUpdate branch September 5, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TypeSpec npm packages in dev container
2 participants