Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeSpec npm packages in dev container #7812

Closed
1 task
brooke-hamilton opened this issue Aug 15, 2024 · 6 comments
Closed
1 task

Update TypeSpec npm packages in dev container #7812

brooke-hamilton opened this issue Aug 15, 2024 · 6 comments
Assignees
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@brooke-hamilton
Copy link
Member

brooke-hamilton commented Aug 15, 2024

Area for Improvement

The postCreateCommand in the dev container runs npm ci in the typespec folder. Some of the packages specified in the package-lock.json file are out of date.

Observed behavior

Building and running the dev container shows that some of the packages need to be updated.

Desired behavior

Packages should be current.

Proposed Fix

  1. Run npm update in the typespec folder and submit a PR for the changes.
  2. Find a way to add this folder to the dependabot checks.

rad Version

0.36

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12985

@brooke-hamilton brooke-hamilton added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Aug 15, 2024
@radius-triage-bot
Copy link

👋 @brooke-hamilton Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@lakshmimsft lakshmimsft added the triaged This issue has been reviewed and triaged label Aug 15, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@rynowak
Copy link
Contributor

rynowak commented Aug 16, 2024

@ytimocin @brooke-hamilton do we know why this isn't covered by depdendabot already?

@ytimocin
Copy link
Contributor

@ytimocin @brooke-hamilton do we know why this isn't covered by depdendabot already?

I will check this.

Another update: when we run npm update and update package-lock.json, our tsp files need a lot of updates too. This work is probably bigger (in terms of scope) than just running the command.

@ytimocin ytimocin removed their assignment Aug 28, 2024
@ytimocin
Copy link
Contributor

Unassigned myself from this issue for now.

@ytimocin ytimocin self-assigned this Oct 8, 2024
@ytimocin
Copy link
Contributor

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants