Update credential precedence in bicepconfig.json #7803

sk593 · 2024-08-12T19:24:14Z

Description

Some workflows need Az authentication and some don't. This removes the default az auth in workflows anytime its not needed

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: sk593 <[email protected]>

github-actions · 2024-08-12T19:33:23Z

Unit Tests

3 297 tests ±0 3 291 ✅ ±0 3m 59s ⏱️ +3s
263 suites ±0 6 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 0f85d87. ± Comparison against base commit 5c10d92.

♻️ This comment has been updated with latest results.

radius-functional-tests · 2024-08-12T19:37:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`667c23d`
Unique ID	func4e7cc2943b
Image tag	pr-func4e7cc2943b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4e7cc2943b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4e7cc2943b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func4e7cc2943b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4e7cc2943b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
❌ Test recipe publishing failed

radius-functional-tests · 2024-08-12T19:42:43Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`1d7b4d0`
Unique ID	func78d7a6f729
Image tag	pr-func78d7a6f729

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func78d7a6f729
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func78d7a6f729
controller test image location: ghcr.io/radius-project/dev/controller:pr-func78d7a6f729
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func78d7a6f729
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded

Signed-off-by: sk593 <[email protected]>

codecov · 2024-08-12T20:12:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (5c10d92) to head (0f85d87).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7803      +/-   ##
==========================================
- Coverage   61.07%   61.05%   -0.03%     
==========================================
  Files         523      523              
  Lines       27446    27446              
==========================================
- Hits        16762    16756       -6     
- Misses       9204     9207       +3     
- Partials     1480     1483       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sk593 <[email protected]>

sk593 · 2024-08-12T20:50:29Z

.github/workflows/functional-test-cloud.yaml

@@ -314,6 +314,64 @@ jobs:
          append: true
          message: |
            :hourglass: Publishing Bicep Recipes for functional tests...
+


Moving this into the build job so we make sure to upload any bicep changes before pushing recipes

Signed-off-by: sk593 <[email protected]>

radius-functional-tests · 2024-08-12T20:58:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`850243a`
Unique ID	func201477f47c
Image tag	pr-func201477f47c

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func201477f47c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func201477f47c
controller test image location: ghcr.io/radius-project/dev/controller:pr-func201477f47c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func201477f47c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded

Signed-off-by: sk593 <[email protected]>

radius-functional-tests · 2024-08-12T21:37:27Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`b2581bb`
Unique ID	funca238c77aa4
Image tag	pr-funca238c77aa4

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca238c77aa4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca238c77aa4
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca238c77aa4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca238c77aa4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded

ytimocin · 2024-08-12T23:07:28Z

.github/workflows/functional-test-cloud.yaml

+      - name: Upload Radius Bicep types artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ matrix.name }}_radius_bicep_types


matrix is not reachable here

Signed-off-by: sk593 <[email protected]>

ytimocin · 2024-08-12T23:18:16Z

.github/workflows/functional-test-cloud.yaml

+        run: |
+          bicep publish-extension ./hack/bicep-types-radius/generated/index.json --target br:${{ env.BICEP_TYPES_REGISTRY }}/test/radius:${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }} --force
+
+      - name: Generate test bicepconfig.json


We have of two of these in this workflow. Is this expected?

yes, the files dont persist between jobs so we need it in both places. the first one is part of the workaround because we need to disable azure auth before we publish the bicep test recipes (this will eventually be removed once the auth bug is fixed) and the second is so we can test against the PR versions of the types (in the event that there are bicep changes in a PR)

ytimocin

Do we need the step that prints out the details of the JSON file in production?

ytimocin · 2024-08-12T23:22:15Z

.github/workflows/validate-bicep.yaml

+      - name: Print updated bicepconfig.json
+        run: cat bicepconfig.json


Do we need this in production?

No, this is in place of the initial workaround since there were authentication issues with the ACR even though we have anonymous pulls. The issue is that when we publish to ACR, we have to authenticate so only having "Environment" authentication removed any Azure CLI auth. Instead, we'll add the "Environment" workaround when we want to disable azure auth. Ideally, we can remove this everywhere in the repo once the bug is fixed: #7804

lakshmimsft

lgtm

radius-functional-tests · 2024-08-12T23:26:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`0f85d87`
Unique ID	funccae2049d7b
Image tag	pr-funccae2049d7b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccae2049d7b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccae2049d7b
controller test image location: ghcr.io/radius-project/dev/controller:pr-funccae2049d7b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccae2049d7b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded

# Description Some workflows need Az authentication and some don't. This removes the default az auth in workflows anytime its not needed ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <[email protected]>

# Description Some workflows need Az authentication and some don't. This removes the default az auth in workflows anytime its not needed ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>

update credential precedence

a77b24a

Signed-off-by: sk593 <[email protected]>

sk593 requested review from a team as code owners August 12, 2024 19:24

sk593 had a problem deploying to functional-tests August 12, 2024 19:24 — with GitHub Actions Failure

sk593 temporarily deployed to functional-tests August 12, 2024 19:35 — with GitHub Actions Inactive

sk593 force-pushed the update-validate-bicep-workaround branch from 667c23d to 1d7b4d0 Compare August 12, 2024 19:39

sk593 temporarily deployed to functional-tests August 12, 2024 19:39 — with GitHub Actions Inactive

sk593 force-pushed the update-validate-bicep-workaround branch from 1d7b4d0 to 3a8df14 Compare August 12, 2024 19:49

sk593 had a problem deploying to functional-tests August 12, 2024 19:49 — with GitHub Actions Failure

testing publish to acr

3a8df14

Signed-off-by: sk593 <[email protected]>

sk593 changed the title ~~Update credential precedence~~ Update credential precedence in bicepconfig.json Aug 12, 2024

sk593 had a problem deploying to functional-tests August 12, 2024 20:00 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workaround branch from aae53b1 to e20fcec Compare August 12, 2024 20:13

sk593 had a problem deploying to functional-tests August 12, 2024 20:13 — with GitHub Actions Failure

sk593 had a problem deploying to functional-tests August 12, 2024 20:15 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workaround branch from f7bef28 to 3bba88b Compare August 12, 2024 20:22

sk593 had a problem deploying to functional-tests August 12, 2024 20:22 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workaround branch from 3bba88b to f62e9cb Compare August 12, 2024 20:24

sk593 had a problem deploying to functional-tests August 12, 2024 20:24 — with GitHub Actions Failure

add temp bicepconfig to validate bicep

f62e9cb

Signed-off-by: sk593 <[email protected]>

sk593 had a problem deploying to functional-tests August 12, 2024 20:28 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workaround branch from f091c18 to f62e9cb Compare August 12, 2024 20:30

sk593 had a problem deploying to functional-tests August 12, 2024 20:30 — with GitHub Actions Failure

sk593 had a problem deploying to functional-tests August 12, 2024 20:34 — with GitHub Actions Failure

nit

ad17b1d

Signed-off-by: sk593 <[email protected]>

sk593 had a problem deploying to functional-tests August 12, 2024 20:49 — with GitHub Actions Failure

sk593 commented Aug 12, 2024

View reviewed changes

sk593 force-pushed the update-validate-bicep-workaround branch from bfabe47 to 850243a Compare August 12, 2024 20:51

sk593 temporarily deployed to functional-tests August 12, 2024 20:52 — with GitHub Actions Inactive

update cloud workflow

850243a

Signed-off-by: sk593 <[email protected]>

nit

45a446e

Signed-off-by: sk593 <[email protected]>

sk593 had a problem deploying to functional-tests August 12, 2024 21:09 — with GitHub Actions Failure

sk593 temporarily deployed to functional-tests August 12, 2024 21:21 — with GitHub Actions Inactive

nit

b2581bb

Signed-off-by: sk593 <[email protected]>

ytimocin requested changes Aug 12, 2024

View reviewed changes

sk593 temporarily deployed to functional-tests August 12, 2024 23:10 — with GitHub Actions Inactive

nit

0f85d87

Signed-off-by: sk593 <[email protected]>

ytimocin reviewed Aug 12, 2024

View reviewed changes

ytimocin approved these changes Aug 12, 2024

View reviewed changes

lakshmimsft approved these changes Aug 12, 2024

View reviewed changes

kachawla approved these changes Aug 13, 2024

View reviewed changes

sk593 merged commit 255c6d8 into main Aug 13, 2024
29 of 30 checks passed

sk593 deleted the update-validate-bicep-workaround branch August 13, 2024 00:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update credential precedence in bicepconfig.json #7803

Update credential precedence in bicepconfig.json #7803

sk593 commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

codecov bot commented Aug 12, 2024 •

edited

Loading

sk593 Aug 12, 2024

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

ytimocin Aug 12, 2024

sk593 Aug 12, 2024

ytimocin Aug 12, 2024

sk593 Aug 12, 2024

ytimocin left a comment

ytimocin Aug 12, 2024

sk593 Aug 12, 2024 •

edited

Loading

lakshmimsft left a comment

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

		- name: Print updated bicepconfig.json
		run: cat bicepconfig.json

Update credential precedence in bicepconfig.json #7803

Update credential precedence in bicepconfig.json #7803

Conversation

sk593 commented Aug 12, 2024 • edited Loading

Description

Type of change

github-actions bot commented Aug 12, 2024 • edited Loading

Unit Tests

radius-functional-tests bot commented Aug 12, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 12, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Aug 12, 2024 • edited Loading

Codecov Report

sk593 Aug 12, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Aug 12, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 12, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Aug 12, 2024

Choose a reason for hiding this comment

sk593 Aug 12, 2024

Choose a reason for hiding this comment

ytimocin Aug 12, 2024

Choose a reason for hiding this comment

sk593 Aug 12, 2024

Choose a reason for hiding this comment

ytimocin left a comment

Choose a reason for hiding this comment

ytimocin Aug 12, 2024

Choose a reason for hiding this comment

sk593 Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

lakshmimsft left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Aug 12, 2024 • edited Loading

Radius functional test overview

Test Status

sk593 commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

codecov bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading

sk593 Aug 12, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 12, 2024 •

edited

Loading