Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bicep build authentication workaround #7804

Closed
1 task
sk593 opened this issue Aug 12, 2024 · 6 comments · Fixed by #7965
Closed
1 task

Revert bicep build authentication workaround #7804

sk593 opened this issue Aug 12, 2024 · 6 comments · Fixed by #7965
Labels
blocked We can't make progress due to external team/factor maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@sk593
Copy link
Contributor

sk593 commented Aug 12, 2024

Area for Improvement

There are a few places in our code where we had to implement workarounds because of this issue: Azure/bicep#14774. The workaround is explained in the issue and removes az auth

Observed behavior

No response

Desired behavior

Once there is a fix for the above issue, we should remove the workarounds in our validate-bicep and functional test workflows

Places we use the workaround:



jq '. + {"cloud": {"credentialPrecedence": ["Environment"]}}' bicepconfig.json > tmp.json && mv tmp.json bicepconfig.json

Proposed Fix

No response

rad Version

GH actions radius version

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12961

@sk593 sk593 added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Aug 12, 2024
@radius-triage-bot
Copy link

👋 @sk593 Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@brooke-hamilton
Copy link
Member

Area for Improvement

There are a few places in our code where we had to implement workarounds because of this issue: Azure/bicep#14774. The workaround is explained in the issue and removes az auth

@sk593 can you please add a link to the workaround.

@lakshmimsft lakshmimsft added the triaged This issue has been reviewed and triaged label Aug 15, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@lakshmimsft lakshmimsft added the blocked We can't make progress due to external team/factor label Aug 15, 2024
@sk593
Copy link
Contributor Author

sk593 commented Sep 3, 2024

Area for Improvement

There are a few places in our code where we had to implement workarounds because of this issue: Azure/bicep#14774. The workaround is explained in the issue and removes az auth

@sk593 can you please add a link to the workaround.

Sure, the workaround is mentioned in the linked issue. This is the comment that explains the workaround: Azure/bicep#14774 (comment)

@kachawla
Copy link
Contributor

kachawla commented Sep 4, 2024

Area for Improvement

There are a few places in our code where we had to implement workarounds because of this issue: Azure/bicep#14774. The workaround is explained in the issue and removes az auth

@sk593 can you please add a link to the workaround.

Sure, the workaround is mentioned in the linked issue. This is the comment that explains the workaround: Azure/bicep#14774 (comment)

@sk593 this came up in triage discussion, it was meant for link to code paths where we have implemented the workaround. Could you please update the issue description to include those links? Mainly to make it easily discoverable for whoever picks this issue up.

@sk593
Copy link
Contributor Author

sk593 commented Sep 4, 2024

Area for Improvement

There are a few places in our code where we had to implement workarounds because of this issue: Azure/bicep#14774. The workaround is explained in the issue and removes az auth

@sk593 can you please add a link to the workaround.

Sure, the workaround is mentioned in the linked issue. This is the comment that explains the workaround: Azure/bicep#14774 (comment)

@sk593 this came up in triage discussion, it was meant for link to code paths where we have implemented the workaround. Could you please update the issue description to include those links? Mainly to make it easily discoverable for whoever picks this issue up.

ah, I misunderstood the comment. just added the code links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked We can't make progress due to external team/factor maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants