Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

rabbitmq-erlang-client should define deps of syntax_tools and compiler #72

Closed
simonxuhao opened this issue Nov 24, 2016 · 3 comments
Closed

rabbitmq-erlang-client should define deps of syntax_tools and compiler #72

simonxuhao opened this issue Nov 24, 2016 · 3 comments
Assignees
@essen
Labels
bug effort-tiny
Milestone
3.6.7

Comments

@simonxuhao
Copy link

with amqp_client in DEPS, release built by erlang.mk can't start:

{{function_clause,[{amqp_gen_connection,terminate,[{undef,[{erl_syntax,form_list,[[{attribute,1,file,{"src/time_compat.erl",1}},...

after adding syntax_tools into LOCAL_DEPS:

{{function_clause,[{amqp_gen_connection,terminate,[{undef,[{compile,forms,[[{attribute,1,file,{"src/time_compat.erl",1}},...

adding compiler into LOCAL_DEPS and it works
@essen essen mentioned this issue Nov 24, 2016
Merged
@essen
Copy link
Contributor

essen commented Nov 24, 2016

PR ready to review and merge.

@michaelklishin michaelklishin added this to the 3.6.7 milestone Nov 24, 2016
@essen essen mentioned this issue Nov 24, 2016
Closed
@michaelklishin
Copy link
Member

michaelklishin commented Nov 24, 2016 •
edited
Loading

Thank you, @Nestor5 and @essen.

michaelklishin added a commit that referenced this issue Nov 25, 2016
@michaelklishin
Start syntax_tools and compiler apps explicitly
712f7b3 
References #72 and rabbitmq/rabbitmq-common#149.

We don't use Erlang releases so need to do this manually :(
Per discussion in the team.
@michaelklishin
Copy link
Member

FTR, we had to do 712f7b3 as well.

dumbbell added a commit that referenced this issue Nov 25, 2016
@dumbbell
amqp_connection: Start syntax_tools and compiler
3663b05 
This is a follow-up commit to 712f7b3.

While here, remove some trailing whitespaces.

References #72 and rabbitmq/rabbitmq-common#149.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@essen essen

Labels
bug effort-tiny
Projects
None yet
Milestone
3.6.7
Development

No branches or pull requests
3 participants
@michaelklishin @essen @simonxuhao