This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Add dependencies on compiler and syntax_tools #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While they don't need to be started, we do depend on them, so should list them as dependencies. This will ensure that they will be included when building releases that include the Erlang client.
michaelklishin
added a commit
to rabbitmq/rabbitmq-erlang-client
that referenced
this pull request
Nov 25, 2016
References #72 and rabbitmq/rabbitmq-common#149. We don't use Erlang releases so need to do this manually :( Per discussion in the team.
|
FTR, we had to do rabbitmq/rabbitmq-erlang-client@712f7b3 as well. |
|
They're application libraries, they do not start any process and therefore do not need to be started. At best they may need to be loaded but only if you set environment values (doesn't sound likely for these). But it doesn't hurt to have this (it'll be a load + noop). |
|
@essen yes but we have a piece of code in the Erlang client that explicitly checks that this app ( |
|
Alright, missed that, thanks. |
dumbbell
added a commit
to rabbitmq/rabbitmq-erlang-client
that referenced
this pull request
Nov 25, 2016
This is a follow-up commit to 712f7b3. While here, remove some trailing whitespaces. References #72 and rabbitmq/rabbitmq-common#149.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While they don't need to be started, we do depend on them,
so should list them as dependencies. This will ensure that
they will be included when building releases that include
the Erlang client.
Fixes rabbitmq/rabbitmq-erlang-client#72.