Add flake8 to the testing #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having automate flake8 is nice, but I'm not sure if |
|
My sense is that E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. The other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety. |
|
If you want to clean up ALL the issues from the second flake8 run and then require the code to pass ALL flake8 tests then I have no objection to that. |
|
Got it, thanks for the explanation. Merging. |
engiecat
pushed a commit
to engiecat/deepvoice3_pytorch
that referenced
this pull request
May 5, 2018
* Add flake8 to the testing * Rerun tests
engiecat
pushed a commit
to engiecat/deepvoice3_pytorch
that referenced
this pull request
May 5, 2018
* Add flake8 to the testing * Rerun tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To automate the discovery of issues like #73 and #74