Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing imports: from . import hparams #74

Merged
merged 6 commits into from
Apr 26, 2018
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 26, 2018

@cclauss cclauss mentioned this pull request Apr 26, 2018
@r9y9
Copy link
Owner

r9y9 commented Apr 26, 2018

I think it should be from hparasm import hparams as same as

from hparams import hparams
.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 26, 2018

Will that work in Python 3 or in Python 2 when from __future__ import absolute_import turn on? If so, then I am good with it.

@r9y9 r9y9 merged commit 7907592 into r9y9:master Apr 26, 2018
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this pull request May 5, 2018
* Add missing imports: from . import hparams

* Add missing import: from . import hparams

* from .hparams import hparams

* from .hparams import hparams

* from hparams import hparams

* from hparams import hparams
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this pull request May 5, 2018
* Add missing imports: from . import hparams

* Add missing import: from . import hparams

* from .hparams import hparams

* from .hparams import hparams

* from hparams import hparams

* from hparams import hparams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants