Do not handle warnings when options("warn") >= 2 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
force-pushed
the
option-warn-lt-2
branch
from
e132771 to
aa1e81d
Compare
yutannihilation
changed the title
|
Thanks! I think passing the warning on in this case makes sense, it also allows you set |
|
Oh, I didn't come up with the usage. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
options("warn")>= 2, a warning is converted into an error. So, in that case, we should not handle it by the warning handler, but do nothing and let it handled by the error handler.This usually won't be a problem, except when a package has some tricky tests that change the value of
options("warn"), but actually evaluate package suffers from this: r-lib/evaluate#81 (comment)I believe this PR will fix the problem, but I'm not fully sure there's no downside... Should this be treated as a known issue?