Do not handle warnings when options("warn") >= 2 (#721)

Pass through warnings when options("warn") >= 2

NEWS.md

@@ -7,6 +7,8 @@
 
 ## Minor improvements and bug fixes
 
+* Pass through warnings when `options(warn = 2)` is set (#721, @yutannihilation).
+
 * `expect_lt()`, `expect_lte()`, `expect_gt()` `expect_gte()` now handle `Inf`
   and `NA` arguments appropriately (#732).
 

R/test-that.R

@@ -122,6 +122,10 @@ test_code <- function(test, code, env = test_env(), skip_on_empty = TRUE) {
     invokeRestart("continue_test")
   }
   handle_warning <- function(e) {
+    # When options(warn) >= 2, a warning will be converted to an error.
+    # So, do not handle it here so that it will be handled by handle_error.
+    if (getOption("warn") >= 2) return()
+
     handled <<- TRUE
     e$expectation_calls <- frame_calls(11, 5)
     register_expectation(e)

tests/testthat/test-expect-error.R

@@ -50,3 +50,10 @@ test_that("generates informative failures", {
     expect_error(stop("xxx"), regexp = "zzz", class = "zzz")
   })
 })
+
+test_that("warnings are converted to errors when options('warn') >= 2", {
+  withr::with_options(
+    c(warn = 2),
+    expect_error(warning("foo"))
+  )
+})