Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use PEP420 style qurator namespace #97

Merged
merged 3 commits into from
Apr 11, 2023
Merged

use PEP420 style qurator namespace #97

merged 3 commits into from
Apr 11, 2023

Conversation

kba
Copy link
Contributor

@kba kba commented Mar 22, 2023

Draft so we can avoid the problems experienced in qurator-spk/dinglehopper#76

@cneud
Copy link
Member

cneud commented Mar 22, 2023

Many thanks! This is up on the TODO List, also for qurator-spk/sbb_binarization#50.

@cneud
Copy link
Member

cneud commented Mar 22, 2023

(CI fails for 3.8 until #91 is merged)

@kba kba marked this pull request as ready for review March 24, 2023 16:56
@cneud cneud added this to the 0.3.0 milestone Mar 31, 2023
@cneud cneud requested a review from vahidrezanezhad April 5, 2023 15:50
@cneud cneud removed this from the 0.3.0 milestone Apr 5, 2023
@vahidrezanezhad vahidrezanezhad merged commit fd56b86 into main Apr 11, 2023
@kba kba deleted the 420-namespace-package branch April 12, 2023 11:26
@kba
Copy link
Contributor Author

kba commented Apr 12, 2023

CI fails for 3.8 with ValueError: bad marshal data (unknown type code) (https://app.circleci.com/pipelines/github/qurator-spk/eynollah/255/workflows/2e29af30-f9fa-4b0e-9d00-a8ad8c1a6a7f/jobs/267) - what is this about?

@cneud
Copy link
Member

cneud commented Apr 12, 2023 •
edited
Loading

This is due to Keras model format using some native Python serialization which is version dependent and was fixed by #91 but I believe the CI cache still has the models in the old HDF5 format. So we need to figure out #98...

@kba
Copy link
Contributor Author

kba commented Apr 12, 2023

This is due to Keras model format using some native Python serialization which is version dependent and was fixed by #91 but I believe the CI cache still has the models in the old HDF5 format. So we need to figure out #98...

Ha, sorry, forgot that was the issue, thanks.

bertsky added a commit to bertsky/eynollah that referenced this pull request Jun 9, 2023
@bertsky
Revert "Merge pull request qurator-spk#97 from qurator-spk/420-namesp…
69c1d6b 
…ace-package"

This reverts commit fd56b86, reversing
changes made to ea792d1.
@bertsky bertsky mentioned this pull request Jun 9, 2023
Merged
cneud added a commit that referenced this pull request Jun 9, 2023
@cneud
Merge pull request #104 from bertsky/reinstate-namespace-pkg
fbe2f23 
Revert "Merge pull request #97 from qurator-spk/420-namespace-package"
bertsky added a commit to bertsky/eynollah that referenced this pull request Jun 10, 2023
@bertsky
Revert "Merge pull request qurator-spk#97 from qurator-spk/420-namesp…
706433c 
…ace-package"

This reverts commit fd56b86, reversing
changes made to ea792d1.
@bertsky bertsky mentioned this pull request Jun 10, 2023
Draft
@bertsky bertsky mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneud cneud cneud approved these changes

@vahidrezanezhad vahidrezanezhad vahidrezanezhad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kba @cneud @vahidrezanezhad