Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #97 from qurator-spk/420-namespace-package" #104

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Revert "Merge pull request #97 from qurator-spk/420-namespace-package" #104

merged 1 commit into from
Jun 9, 2023

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Jun 9, 2023

This reverts commit fd56b86 (i.e. #97), reversing changes made to ea792d1 (i.e. 7cd07dd).

Motivation: page2tsv and sbb_utils still use qurator as namespace, and this inconsistency leads to

ModuleNotFoundError: No module named 'qurator.eynollah'

@bertsky
Revert "Merge pull request qurator-spk#97 from qurator-spk/420-namesp…
69c1d6b 
…ace-package"

This reverts commit fd56b86, reversing
changes made to ea792d1.
kba
kba approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go away once there is a decision on how to proceed with the qurator namespace and which mechanism to use for those, but for now this makes eynollah work together with the other qurator packages.

@cneud cneud merged commit fbe2f23 into qurator-spk:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

@cneud cneud cneud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertsky @kba @cneud