-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary workaround for gcc 14 libstdc++ incompatibility with HIP #857
Conversation
Weiqun suggests adding Strangely, adding |
Edit: this doesn't really work for us, since we have templated everything, almost every file includes everything else. |
Adding |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
Description
Temporarily workaround incompatibilities between the C++ standard library headers shipped with GCC 14 and HIP by switching to using the C++ standard library headers shipped with Clang (an independent implementation).
This may not be viable in production, since (in principle) any third-party libraries that use C++ should be complied against the same C++ standard library in order to ensure compatibility, but it will at least allow the CI to pass again and unblock several PRs. Currently, the only C++ library dependency that is not built simultaneously alongside Quokka is ADIOS2, which is optional.
Related issues
Fixes #856.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.