Drop all references to Xilium.CefGlue #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I was hoping to get to this today, but I ran out of time. I'm out of town for a week, but will give this a spin when I get back. I'm a little hesitant of doing a cactbot release without testing this locally a bit more thoroughly and so don't want to rush this. I've definitely had a number of race conditions (and still do) with loading, and so I don't want to introduce more. |
quisquous
added a commit
that referenced
this pull request
Jul 23, 2019
SiliconExarch
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My updated OverlayPlugin doesn't use CefGlue so trying to load Cactbot with that fails right now.
Cactbot either needs to use CefSharp (which I'm using) or drop all references to Xilium.CefGlue.
Switching to CefSharp would break compatibility with the old OverlayPlugin so I'd rather avoid that.
This change should be compatible with both versions. I've tested this change with my updated version but not with the old one. If it breaks, the most likely cause is that trying to execute JavaScript before the page is loaded is silently ignored. In that case I'll have to think of a better solution to the issue.