Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hibiyasleep (and OverlayPlugin in general?) no longer supported? #553

Closed
amackenzie opened this issue Aug 19, 2019 · 5 comments
Closed

hibiyasleep (and OverlayPlugin in general?) no longer supported? #553

amackenzie opened this issue Aug 19, 2019 · 5 comments

Comments

@amackenzie
Copy link

It seems like according to hibiyasleep/OverlayPlugin#37 that OverlayPlugin in general isn't going to be updated or anything going forward, will this be an issue for Cactbot? It looks like there haven't been any changes for years as it is.

@markuznw
Copy link

markuznw commented Aug 19, 2019

There is @ngld picking it up for what I know, his modified version (https://github.com/ngld/OverlayPlugin) works much better than the original for me despite still being in beta phase. The problem is cactbot (and other plugins) aren't yet compatible by default.

There was pull #442 to make it compatible but it got reverted due to issues. I hope they can figure it out and make it compatible with both versions :)

@quisquous
Copy link
Owner

There's not really anything to worry about here. Either I'll support the OverlayPlugin myself if something breaks or I'll move to ngld's version. I'm still planning on moving to ngld's version, but haven't sorted out all the issues yet.

@ngld
Copy link
Contributor

ngld commented Aug 20, 2019

FWIW, I've done most of the porting work already (https://github.com/ngld/cactbot/tree/feature/eventSource). It's not completely done, yet (pulltimer doesn't work).
I'm planning on doing some more testing and eventually make it backwards compatible with the old OverlayPlugin though that might be a PITA. Not sure, yet.

Oh, as an added bonus, Cactbot works over WebSocket with my OverlayPlugin so you can put it in OBS if you want to.

@sajid-ahmad
Copy link

What's OBS?

@tant4lus
Copy link

OBS is Open Broadcaster Software. It's one of the many programs you can use to stream your gameplay to Twitch.

SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this issue Dec 31, 2024
Feint also applies to magical damage at reduced efficacy since
Endwalker. I don't think we're using this anywhere anymore, but update
it anyways for consistency.
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Dec 31, 2024
Feint also applies to magical damage at reduced efficacy since
Endwalker. I don't think we're using this anywhere anymore, but update
it anyways for consistency. e85c261
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Dec 31, 2024
Feint also applies to magical damage at reduced efficacy since
Endwalker. I don't think we're using this anywhere anymore, but update
it anyways for consistency. e85c261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants