refactor(build-workflow): infer image tag from branch name (PROJQUAY-2612) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmage
approved these changes
Oct 4, 2021
flavianmissi
added a commit
to flavianmissi/quay-operator
that referenced
this pull request
Oct 4, 2021
…2612) (quay#556) This change ties the build workflow to the name of the branches it runs against. In a future where downstream releases are fully (or nearly) automated, we should probably tag the redhat-* branches for everything we want built, alpha, release candidates, etc. When this is done, this workflow should be updated to get triggered when new tags are created.
flavianmissi
added a commit
to flavianmissi/quay-operator
that referenced
this pull request
Oct 4, 2021
…2612) (quay#556) This change ties the build workflow to the name of the branches it runs against. In a future where downstream releases are fully (or nearly) automated, we should probably tag the redhat-* branches for everything we want built, alpha, release candidates, etc. When this is done, this workflow should be updated to get triggered when new tags are created.
flavianmissi
added a commit
that referenced
this pull request
Oct 5, 2021
* chore: github workflow to publish container images (PROJQUAY-2556) (#530) * feat: setup e2e nightly run (PROJQUAY-2556) (#535) * fix(workflow): use correct clair and builder-qemu tags (#553) * fix: use clair nightly build clair is in the process of removing their redhat-* branches, and asked us to use their nightly instead. also use correct tag for qemu builder image. * fix(build): use bundle image digest instead of tag (PROJQUAY-2556) (#557) and use env var to set it. increase e2e timeout too, as 3 minutes ins't always enough for the mirror to get up and running. * refactor(build-workflow): infer image tag from branch name (PROJQUAY-2612) (#556) This change ties the build workflow to the name of the branches it runs against. In a future where downstream releases are fully (or nearly) automated, we should probably tag the redhat-* branches for everything we want built, alpha, release candidates, etc. When this is done, this workflow should be updated to get triggered when new tags are created. * fix(build): add missed curly braces in expression (#559) * fix: pull correct image on build workflow (PROJQUAY-2556) (#560) * fix: use correct pull syntax on workflow (PROJQUAY-2556)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ties the build workflow to the name of the branches it runs against.
In a future where downstream releases are fully automated, we should probably tag the redhat-* branches (for everything we want built, alpha, release candidates, etc). When we do this, this workflow should be updated to get triggered when new tags are created, so that it's more robust.
Successful workflow run: https://github.com/flavianmissi/quay-operator/actions/runs/1295760888